This repository was archived by the owner on Jan 24, 2025. It is now read-only.
Update nodejs client documentation + small fixes to JSON RPC client #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-v-in
approved these changes
Jan 11, 2022
Parameters of log action were not read correctly when a tag was passed as single parameter. In this case the passed tag was interpreted as log level and the default tag used.
Now calls like `node remote.js --silent mining` correctly treat the --silent as boolean flag instead of assigning the following value to it. Previously, 'mining' would have been assigned to `silent` and the action `mining` would have been omitted.
f5b4d4a to
393d7ca
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
What's in this pull request?
This PR updates the documentation for the nodejs client and the JSON RPC client.
The separate .md documentations as well as the usage instructions included in the clients and the sample configurations file have been updated.
All deprecated options are now reported as being deprecated.
Additionally, two small fixes for the reading of parameters in the JSON RPC client are included.