Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7aaed53
fix: high-priority code quality issues - partial progress
njfio Jul 14, 2025
c1885b7
fix: complete high-priority code quality issues (1,2,4,5,6)
njfio Jul 14, 2025
a096e65
chore: move ad-hoc error_fixer utility to examples/legacy
njfio Aug 8, 2025
3562ad7
feat(agent): add timeout and output limits to run_command; keep stric…
njfio Aug 8, 2025
733fe32
fix(cli): return proper error on argument parse failure for consisten…
njfio Aug 8, 2025
64b7e6f
chore(cache): remove unnecessary async from RedisCache::new and Datab…
njfio Aug 8, 2025
37e5ec1
fix(cache): adjust MultiLevelCache::new to call non-async Redis/Datab…
njfio Aug 8, 2025
efd840d
chore(executor): remove unnecessary async from sorting helper and adj…
njfio Aug 8, 2025
34c8fff
ci: add rustfmt check and clippy jobs to CI workflow
njfio Aug 8, 2025
f50d06a
feat(security): add centralized secret redaction and apply to engine …
njfio Aug 8, 2025
835539a
feat(cli): standardize exit codes and sanitize error output; add type…
njfio Aug 8, 2025
1b752ee
fix(security): correct secret redaction regexes and implementation
njfio Aug 8, 2025
521d774
chore(core): add once_cell dependency for redaction
njfio Aug 8, 2025
f7768d5
fix(security): use redacted error text in base_engine error returns
njfio Aug 8, 2025
abb20ba
fix(security): adjust RE_AUTH_BEARER replacement to non-closure to sa…
njfio Aug 8, 2025
22244c4
refactor(agent): switch MCP adapter tests to AsyncSqliteMemoryStore
njfio Aug 8, 2025
a789360
refactor(tests): migrate agent tests to AsyncSqliteMemoryStore and ad…
njfio Aug 8, 2025
9048364
refactor(tests): fix typos and await AsyncSqliteMemoryStore construct…
njfio Aug 8, 2025
bb30757
refactor(memory): switch internal tests to AsyncSqliteMemoryStore and…
njfio Aug 8, 2025
131f5db
refactor(memory): remove deprecated SqliteMemoryStore; test(redaction…
njfio Aug 8, 2025
aeb8b8e
feat(cli): map config load errors to CliError; chore(cache): return h…
njfio Aug 8, 2025
012994b
feat(cli): map engine/pipeline/tools command errors to typed CliError…
njfio Aug 8, 2025
caad9b6
test(cli): add exit code tests for argparse, missing pipeline file, e…
njfio Aug 8, 2025
0d9a516
chore: add basic pre-commit hooks for rustfmt, clippy, and common fil…
njfio Aug 8, 2025
2151738
feat: phase 1 TODO - enhanced agent system with memory, planning, and…
njfio Aug 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .augment/rules/prepare-and-create-high-quality-pull-request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
---
type: "agent_requested"
description: "Follow this exact protocol step-by-step to ensure the codebase is in excellent shape, all documentation is relevant and up-to-date, and a changelog is maintained before creating a new pull request (PR). Do not skip any steps. Report back on each step's outcome for verification."
---
repare and Create a High-Quality Pull Request
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Typo in title: “repare” → “Prepare”.

This is user-facing process documentation; fix the heading.

-repare and Create a High-Quality Pull Request
+Prepare and Create a High-Quality Pull Request
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
repare and Create a High-Quality Pull Request
Prepare and Create a High-Quality Pull Request
🤖 Prompt for AI Agents
In .augment/rules/prepare-and-create-high-quality-pull-request.md around line 5,
the heading contains a typo "repare and Create a High-Quality Pull Request";
update the heading to "Prepare and Create a High-Quality Pull Request"
(capitalize consistently) to correct the spelling and ensure user-facing
documentation reads correctly.


Follow this exact protocol step-by-step to ensure the codebase is in excellent shape, all documentation is relevant and up-to-date, and a changelog is maintained before creating a new pull request (PR). Do not skip any steps. Report back on each step's outcome for verification.

Review and Optimize the Codebase:
Perform a full code review: Check for code quality, bugs, inefficiencies, and adherence to best practices (e.g., using linters like ESLint for JS or pylint for Python if applicable).
Run all tests (unit, integration, etc.) to ensure 100% pass rate. Fix any failures.
Ensure the code is modular, readable, and follows the project's style guide (e.g., PEP 8 for Python).
Remove any dead code, unused variables, or deprecated features.
Confirm the branch is up-to-date with the main branch (e.g., via git pull origin main and resolve conflicts).
Update and Prune Documentation:
Review all documentation files (e.g., README.md, API docs, user guides, inline comments).
Update any sections that are outdated features, APIs, or instructions to match the current codebase.
Remove any documentation files or sections that are no longer relevant (e.g., docs for removed features). If a file is partially irrelevant, refactor it instead of deleting.
Add new documentation where needed (e.g., for new features or changes).
Ensure docs are clear, concise, and formatted consistently (e.g., use Markdown best practices).
If the project lacks one, create or update a CHANGELOG.md file following the Keep a Changelog format. Append entries for this change under sections like "Added," "Changed," "Fixed," or "Removed," including version numbers and dates.
Stage and Commit Changes:
Stage all modified, added, or deleted files (e.g., via git add .).
Create a clean commit history: Use descriptive commit messages (e.g., "feat: Add user authentication" following Conventional Commits). Squash unnecessary commits if the history is messy.
Commit all changes with a final message summarizing the updates (e.g., "Update codebase, docs, and changelog for feature X").
Create the Pull Request:
Push the branch to the remote repository (e.g., git push origin <branch-name>).
Create a new PR on GitHub targeting the main branch.
Use a clear, concise title (e.g., "Enhance user auth with improved security").
In the PR description, include:
A summary of changes.
Links to related issues.
Before/after details for major updates.
Confirmation that tests pass, docs are updated, and changelog is appended.
Screenshots or examples if applicable.
Keep the PR small and focused—if changes are large, suggest splitting into multiple PRs.
Assign reviewers and add labels (e.g., "enhancement," "documentation").
Final Verification and Reporting:
Double-check that the codebase is stable (e.g., no lint errors, all tests pass).
If any issues arise during these steps, fix them and note them in the PR description.
Output a success message with the PR URL once created.
26 changes: 26 additions & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,29 @@ jobs:
uses: softprops/action-gh-release@v1
with:
files: ./artifacts/*.tar.gz

fmt:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Install latest stable
uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
components: rustfmt
- name: cargo fmt --check
run: cargo fmt --all -- --check

Comment on lines +124 to +136
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Upgrade actions to supported versions and fail on clippy warnings.

Actionlint flags actions/checkout@v3 and actions-rs/toolchain@v1 as too old. Switch to checkout@v4 and dtolnay/rust-toolchain@stable, and make clippy fail on warnings.

Apply this diff to the new jobs:

   fmt:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - name: Install latest stable
-        uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-          override: true
-          components: rustfmt
+      - uses: actions/checkout@v4
+      - name: Install latest stable
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          components: rustfmt
       - name: cargo fmt --check
         run: cargo fmt --all -- --check
 
   clippy:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - name: Install latest stable
-        uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-          override: true
-          components: clippy
+      - uses: actions/checkout@v4
+      - name: Install latest stable
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          components: clippy
       - name: cargo clippy
-        run: cargo clippy --all-targets --all-features
+        run: cargo clippy --all-targets --all-features -D warnings

Also applies to: 137-149

🧰 Tools
🪛 actionlint (1.7.7)

127-127: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)


129-129: the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🤖 Prompt for AI Agents
.github/workflows/rust.yml around lines 124-136 (and similarly 137-149): update
deprecated GH Actions and make clippy fail-on-warnings; replace uses:
actions/checkout@v3 with actions/checkout@v4 and replace uses:
actions-rs/toolchain@v1 with dtolnay/rust-toolchain@stable (or the maintained
rust-toolchain action) and adjust inputs accordingly to install stable toolchain
and rustfmt component; additionally ensure clippy runs with -- -D warnings (or
set RUSTFLAGS/CARGO_CLIPPY_ARGS) so Clippy treats warnings as errors and update
job names/steps consistently across the duplicated job block at 137-149.

clippy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Install latest stable
uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
components: clippy
- name: cargo clippy
run: cargo clippy --all-targets --all-features
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,4 @@ fluent_cache*
# Large generated files
enhanced_reflection_profiling_report.txt
reasoning_engine_profiling_report.txt
key_safe.txt
21 changes: 21 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.6.0
hooks:
- id: check-yaml
- id: end-of-file-fixer
- id: trailing-whitespace
- repo: local
hooks:
- id: rustfmt
name: rustfmt
entry: cargo fmt --all --
language: system
types: [rust]
pass_filenames: false
- id: clippy
name: clippy
entry: cargo clippy --all-targets
language: system
types: [rust]
pass_filenames: false
Comment on lines +16 to +21
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Ensure clippy fails on warnings and covers all features

Pre-commit should block commits on new warnings. Add -D warnings and consider --all-features to match CI rigor.

Apply:

-      - id: clippy
-        name: clippy
-        entry: cargo clippy --all-targets
+      - id: clippy
+        name: clippy
+        entry: cargo clippy --all-targets --all-features -- -D warnings
         language: system
         types: [rust]
         pass_filenames: false
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- id: clippy
name: clippy
entry: cargo clippy --all-targets
language: system
types: [rust]
pass_filenames: false
- id: clippy
name: clippy
entry: cargo clippy --all-targets --all-features -- -D warnings
language: system
types: [rust]
pass_filenames: false
🤖 Prompt for AI Agents
In .pre-commit-config.yaml around lines 16 to 21 the clippy hook does not fail
on warnings nor covers all crate features; update the entry command to run cargo
clippy --all-targets -D warnings --all-features (or at least --all-features if
desired) so the hook fails on warnings and matches CI rigor, preserving
language/system and pass_filenames: false.

Loading
Loading