Add overloads for more key types to ordered_map and fix ordered_map::erase(first, last) with first == last#3564
Merged
nlohmann merged 3 commits intonlohmann:developfrom Jul 4, 2022
Conversation
Add overloads to accept additional key types defined by type trait detail::is_usable_as_key_type to ordered_map. The same key types that can be used with json can now also be used with ordered_json.
78cbfbf to
ab47d01
Compare
gregmarr
approved these changes
Jun 29, 2022
Owner
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the overloads we missed in the
string_viewPR toordered_map.The type trait
is_usable_as_key_type(introduced in thestring_viewPR) was refactored intois_usable_as_basic_json_key_type(equivalent tois_usable_as_key_typebefore the PR), andis_usable_as_key_type, which now accepts a comparator and key type directly. No functional change is intended.Extending the element_access2 unit test to also cover
ordered_jsonrevealed a bug inordered_mapthat is also fixed by this patch.Fixes #3558.