Add support for double-click word selection#840
Merged
Conversation
Owner
noborus
commented
Sep 1, 2025
- Implement double-click detection with configurable interval and distance
- Add word boundary detection for smart text selection
- Enhance mouse event handling with click state management
- Support alphanumeric, whitespace, and symbol character types
- Improve user experience with intuitive text selection
- Implement double-click detection with configurable interval and distance - Add word boundary detection for smart text selection - Enhance mouse event handling with click state management - Support alphanumeric, whitespace, and symbol character types - Improve user experience with intuitive text selection
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements double-click word selection functionality to enhance the text editor's user experience. The feature enables users to quickly select words by double-clicking, with intelligent word boundary detection based on character types.
Key changes:
- Added configurable double-click detection with timing and distance thresholds
- Implemented smart word boundary detection that differentiates between alphanumeric, whitespace, and symbol characters
- Refactored mouse event handling to support click state management and improved selection logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| oviewer/oviewer.go | Added clickState field to Root struct for tracking mouse click state |
| oviewer/mouse.go | Implemented double-click detection, word boundary finding, and refactored mouse selection handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
oviewer/mouse.go
Outdated
Comment on lines
293
to
303
| return 0 // Out of range is treated as whitespace | ||
| } | ||
|
|
||
| char := line.lc[contentX].mainc | ||
| if char == ' ' || char == '\t' { | ||
| return 1 // Whitespace | ||
| } | ||
| if unicode.IsLetter(char) || unicode.IsDigit(char) || char == '_' { | ||
| return 2 // Alphanumeric and underscore | ||
| } | ||
| return 3 // Other characters |
There was a problem hiding this comment.
Using magic numbers (0, 1, 2, 3) for character types reduces code readability. Consider defining constants like const (CharTypeWhitespace = 0; CharTypeAlphanumeric = 1; ...) to make the code more self-documenting.
Suggested change
| return 0 // Out of range is treated as whitespace | |
| } | |
| char := line.lc[contentX].mainc | |
| if char == ' ' || char == '\t' { | |
| return 1 // Whitespace | |
| } | |
| if unicode.IsLetter(char) || unicode.IsDigit(char) || char == '_' { | |
| return 2 // Alphanumeric and underscore | |
| } | |
| return 3 // Other characters | |
| return charTypeOutOfRange // Out of range is treated as whitespace | |
| } | |
| char := line.lc[contentX].mainc | |
| if char == ' ' || char == '\t' { | |
| return charTypeWhitespace // Whitespace | |
| } | |
| if unicode.IsLetter(char) || unicode.IsDigit(char) || char == '_' { | |
| return charTypeAlphanumeric // Alphanumeric and underscore | |
| } | |
| return charTypeOther // Other characters |
Comment on lines
218
to
221
| if timeDiff > DoubleClickInterval { | ||
| root.resetClickState() // Reset if too much time has passed | ||
| return false | ||
| } |
There was a problem hiding this comment.
The side effect of calling resetClickState() inside isDoubleClick() makes the function less predictable. Consider moving this reset logic to the caller (updateClickState) to keep isDoubleClick() as a pure query function.
Co-authored-by: Copilot <[email protected]>
- Replace isDoubleClick boolean function with checkClickType enum return - Add ClickType enum (ClickSingle, ClickDouble, ClickExpired) for clearer state handling - Consolidate click state management logic in handlePrimaryButtonClick - Add character type constants for better code readability - Reduce code duplication by centralizing timeout and reset logic This improves the maintainability of the double-click detection system and makes the click handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.