Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: fix typo ( diagnotic → diagnostic ) #39045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2021
Merged

test: fix typo ( diagnotic → diagnostic ) #39045

merged 1 commit into from
Jun 16, 2021

Conversation

houssemchebeb
Copy link
Contributor

Fixed typo

diagnotic → diagnostic

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 15, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. and removed needs-ci PRs that need a full CI run. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 15, 2021
aduh95
aduh95 approved these changes Jun 15, 2021
View reviewed changes
@cjihrig cjihrig added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 16, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @cjihrig. Please 👍 to approve.

@houssemchebeb @aduh95
test: fix typo
dc2f6b6 
PR-URL: nodejs#39045
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@aduh95 aduh95 force-pushed the fix-typo-readme branch from 5a16629 to dc2f6b6 Compare June 16, 2021 08:21
@aduh95
Copy link
Contributor

aduh95 commented Jun 16, 2021

Landed in dc2f6b6

@aduh95 aduh95 merged commit dc2f6b6 into nodejs:master Jun 16, 2021
@houssemchebeb houssemchebeb deleted the fix-typo-readme branch June 16, 2021 08:55
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
@houssemchebeb @danielleadams
test: fix typo
bd92461 
PR-URL: #39045
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 21, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@houssemchebeb @richardlau
test: fix typo
1069c95 
PR-URL: #39045
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@houssemchebeb @richardlau
test: fix typo
4009350 
PR-URL: #39045
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@houssemchebeb @foxxyz
test: fix typo
d608686 
PR-URL: nodejs#39045
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@houssemchebeb @aduh95 @cjihrig @richardlau @Lxxyx