Open
Conversation
| time_passed = 0 | ||
|
|
||
| while time_passed < 5: | ||
| for time_passed in range(5): |
Author
There was a problem hiding this comment.
Function topper refactored with the following changes:
- Replace while with for (
while-to-for)
Comment on lines
-57
to
+54
| if value: | ||
| level = logging.INFO | ||
| else: | ||
| level = logging.WARNING | ||
| level = logging.INFO if value else logging.WARNING |
Author
There was a problem hiding this comment.
Function verbosity_callback refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-44
to
+49
| def validate_delay(cls, val): # pylint: disable=no-self-use,no-self-argument | ||
| def validate_delay(cls, val): # pylint: disable=no-self-use,no-self-argument | ||
| """Check if the delay used by user is values. If not, use closest logical values.""" | ||
| if val not in range(0, 101): | ||
| logging.warning("delay must be within 0 to 100 seconds") | ||
| if val > 100: | ||
| val = 100 | ||
| if val < 0: | ||
| val = 0 | ||
| val = min(val, 100) | ||
| val = max(val, 0) |
Author
There was a problem hiding this comment.
Function PastSettings.validate_delay refactored with the following changes:
- Replace comparison with min/max call [×2] (
min-max-identity)
Comment on lines
-70
to
+83
| tutorial_link = "Learn more http://bit.ly/configure-tgcf" | ||
|
|
||
| if CONFIG_FILE_NAME in os.listdir(): | ||
| logging.info(f"{CONFIG_FILE_NAME} detected") | ||
| return 1 | ||
| if os.getenv("TGCF_CONFIG"): | ||
| logging.info(f"env var {CONFIG_ENV_VAR_NAME} detected") | ||
| if not ".env" in os.listdir(): | ||
| return 2 | ||
| if not os.getenv("TGCF_CONFIG"): | ||
| return 0 | ||
| logging.info(f"env var {CONFIG_ENV_VAR_NAME} detected") | ||
| if ".env" not in os.listdir(): | ||
| return 2 | ||
|
|
||
| tutorial_link = "Learn more http://bit.ly/configure-tgcf" | ||
|
|
||
| logging.warning( | ||
| f"If you can create files in your system,\ | ||
| logging.warning( | ||
| f"If you can create files in your system,\ | ||
| you should use tgcf.config.yml and not .env to define configuration {tutorial_link}" | ||
| ) | ||
| sys.exit(1) | ||
| else: | ||
| return 0 | ||
| ) | ||
| sys.exit(1) |
Author
There was a problem hiding this comment.
Function detect_config_type refactored with the following changes:
- Move assignments closer to their usage (
move-assign) - Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else) - Simplify logical expression using De Morgan identities (
de-morgan)
Comment on lines
-104
to
+101
| if config_dict: | ||
| config = Config(**config_dict) | ||
| else: | ||
| config = Config() | ||
| config = Config(**config_dict) if config_dict else Config() |
Author
There was a problem hiding this comment.
Function read_config refactored with the following changes:
- Simplify conditional into switch-like form (
switch) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-29
to
+32
| if not len(splitted) == 2: | ||
| if len(splitted) != 2: | ||
| splitted = text.split("\n", 1) | ||
| if not len(splitted) == 2: | ||
| return "" | ||
| if len(splitted) != 2: | ||
| return "" |
Author
There was a problem hiding this comment.
Function get_args refactored with the following changes:
- Simplify logical expression using De Morgan identities [×2] (
de-morgan) - Hoist conditional out of nested conditional (
hoist-if-from-if)
| def display_forwards(forwards: List[Forward]) -> str: | ||
| """Return a string that beautifully displays all current forwards.""" | ||
| if len(forwards) == 0: | ||
| if not forwards: |
Author
There was a problem hiding this comment.
Function display_forwards refactored with the following changes:
- Simplify sequence length comparison (
simplify-len-comparison)
|
|
||
| try: | ||
| plugin_module = import_module("tgcf.plugins." + plugin_id) | ||
| plugin_module = import_module(f"tgcf.plugins.{plugin_id}") |
Author
There was a problem hiding this comment.
Function load_plugins refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Simplify logical expression using De Morgan identities (
de-morgan) - Add single value to dictionary directly rather than using update() (
simplify-dictionary-update)
|
|
||
| async def modify(self, tm: TgcfMessage) -> TgcfMessage: | ||
| if not tm.file_type in ["gif", "video", "photo"]: | ||
| if tm.file_type not in ["gif", "video", "photo"]: |
Author
There was a problem hiding this comment.
Function TgcfMark.modify refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
| async def modify(self, tm: TgcfMessage) -> TgcfMessage: | ||
|
|
||
| if not tm.file_type in ["photo"]: | ||
| if tm.file_type not in ["photo"]: |
Author
There was a problem hiding this comment.
Function TgcfOcr.modify refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!