Fix the code to be runnable in Python 3.14 (but do not enable it officially yet) #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `asyncio.iscoroutinefunction()` is deprecated in Python 3.14. Signed-off-by: Sergey Vasilyev <[email protected]>
Signed-off-by: Sergey Vasilyev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extraction from
This PR fixes Kopf to be runnable with Python 3.14 but does not enable Python 3.14 in CI yet. In other words, there is no official support for Python 3.14, but the code should be runnable (at your own risk).
Full Python 3.14 support is blocked by errors in the API tests of unknown origin, which should be fixed by rewrting tests to KMock, which in turn has to be initially released ("soon"). Since this can take some time, the Python 3.14 official support is on pause, but the code is made runnable in 3.14 nevertheless — only 2 small incompatibilities were blocking it.