Make the ToBytes trait unsafe #956
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
In your opinion, how public should this trait actually be? I looked through the library, and this trait is only used in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the
ToBytesimpls on arrays and slices, which do not make use ofto_bytesof the underlying type, implementingToBytesmakes a promise to unsafe code. This should be explicit, by having the trait itself be unsafe.Also replaces the impl for
&[T]with one for[T], to avoid depending on the layout of&[T]. This is, technically, a breaking change – however, the code that would break didn't actually work at runtime in the first place.