chore: Improve link accessibility for screen reader users #8604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Sep 29, 2025
There was a problem hiding this comment.
Fwiw, I'm using tooling to identify things to fix (previous PRs were more or less reading while running the tooling, whereas this is the first PR based on the precise complaints from the tooling).
| t.test('files can link to root pages', async t => { | ||
| await testBuildDocs(t, { | ||
| content: { 'test.md': '[link](/test)' }, | ||
| content: { 'test.md': '[Test](/test)' }, |
There was a problem hiding this comment.
I understand this is a test as opposed to something that's read by a real user/screen reader, but people have a tendency to copy and paste from tests -- treating them as sample code, so unless there's a good reason not to fix a test, I prefer to offer a fix for it too.
There was a problem hiding this comment.
No worries, you're 100% right fixing even these.
wraithgar
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use
(click) herelinksFor more information, see:
References