Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix!: honors ignoreScripts option to prevent prepare lifecycle script #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix!: honors ignoreScripts option to prevent prepare lifecycle script #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8254e9
fix!: honors `ignoreScripts` option to prevent `prepare` lifecycle sc…
reggi Oct 15, 2024
f767a41
Delete test/fixtures/prepare-ignore/package.json
reggi Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/dir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ class DirFetcher extends Fetcher {
if (!mani.scripts || !mani.scripts.prepare) {
return
}
if (this.opts.ignoreScripts) {
return
}

// we *only* run prepare.
// pre/post-pack is run by the npm CLI for publish and pack,
Expand Down
26 changes: 26 additions & 0 deletions test/dir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,3 +164,29 @@ t.test('fails without a tree or constructor', async t => {
const f = new DirFetcher(abbrevspec, {})
t.rejects(() => f.extract(me + '/prepare'))
})

t.test('with prepare script and ignoreScripts true', async t => {
let shouldNotBePopulated = false

const DirFetcherIsolate = t.mock('../lib/dir.js', {
'@npmcli/run-script': () => {
shouldNotBePopulated = true
},
})

const dir = t.testdir({
'package.json': JSON.stringify({
name: 'meow',
version: '1.0.0',
scripts: {
prepare: 'noop',
},
}),
})
const f = new DirFetcherIsolate(`file:${relative(process.cwd(), dir)}`, {
tree: await loadActual(dir),
ignoreScripts: true,
})
await f.extract(me + '/prepare-ignore')
t.ok(!shouldNotBePopulated)
})
Loading