Add .NET 10 TFM and clean up usings #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for .NET 10 by updating target framework monikers across the project and test solution. The PR also performs cleanup of unused using statements across multiple source files.
- Adds .NET 10 as a target framework alongside existing .NET 6, .NET 8, and .NET Standard targets
- Updates test dependencies to newer versions (Microsoft.NET.Test.Sdk 18.0.1, xunit 2.9.3, xunit.runner.visualstudio 3.1.5)
- Removes unused using statements from 7 source files to improve code cleanliness
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/NReco.Logging.Tests/NReco.Logging.Tests.csproj | Adds net10.0 TFM and updates test package dependencies to newer versions |
| src/NReco.Logging.File/NReco.Logging.File.csproj | Adds net10.0 TFM with corresponding Microsoft.Extensions.* package references, updates description and title |
| src/NReco.Logging.File/Format/StringLogEntryFormatter.cs | Removes unused System.Collections.Generic using and reorders remaining usings |
| src/NReco.Logging.File/FileLoggerProvider.cs | Removes unused using statements (System.Collections.Generic, System.Text, Microsoft.Extensions.Configuration) and reorders remaining ones |
| src/NReco.Logging.File/FileLoggerOptions.cs | Removes multiple unused using statements (System.Collections.Generic, System.Linq, System.Threading.Tasks, System.IO, System.Collections.Concurrent, System.Text, Microsoft.Extensions.Configuration) |
| src/NReco.Logging.File/FileLoggerExtensions.cs | Removes unused using statements (System.Collections.Generic, System.Linq, System.IO, NReco.Logging.File) and reorders remaining ones |
| src/NReco.Logging.File/FileLoggerConfig.cs | Removes multiple unused using statements (System, System.Collections.Generic, System.Linq, System.Threading.Tasks, System.IO, System.Collections.Concurrent, System.Text, Microsoft.Extensions.Configuration) |
| src/NReco.Logging.File/FileLogger.cs | Removes unused using statements (System.Buffers, System.Text) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since .NET 10 is out for a few days now, I've added it to the compatible TFM list so the package is natively compiled for it. I also updated the Test solution and the dependencies there.
In another commit I deleted unused usings from the .cs files to clean up a bit.
All Tests still pass.
Since .NET 6 is EoL for a year now should the TFM target be left inside or removed? I wasn't sure so I still let it in. Is your decision in the end. 🙂