-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(repo): split slow e2e tests - misc, run, workspace, and react c… #33009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ypress Split the following test suites into smaller, more focused tests: - nx misc tests (cross-workspace, format, global installation, help, migrate, report/list, show) - nx run tests (bail, exec, forwarding params, many, one, targets) - workspace tests (convert to monorepo, infer targets, move project, npm package, remove project) - react cypress component tests (app, async webpack, buildable, lib, vite) - react module federation rspack tests (promise-based, var, versions)
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
|
View your CI Pipeline Execution ↗ for commit 9ec289d
☁️ Nx Cloud last updated this comment at |
Resolved conflict in e2e/nx/src/misc.test.ts by removing the file as it was intentionally split into smaller test files in this branch.
Added the new pnpm catalog test that was added to misc.test.ts in upstream commit e8bd83e to our split misc-migrate.test.ts file. This includes: - Updated mock fetcher to handle react, react-dom, and lodash packages - New test for pnpm catalog references and catalog definition updates - Import of getSelectedPackageManager from @nx/e2e-utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
This failure is classified as 'environment_state' because:
-
The error is explicitly a cache/persistence problem: The Cypress binary is missing from the expected cache location
/home/workflows/.cache/Cypress/14.5.4/Cypress/Cypress, and the error message directly states "You ran 'npm install' at an earlier build step but did not persist: /home/workflows/.cache/Cypress". -
The PR only splits existing test files: This is a test refactoring PR that extracts tests from larger suites (misc.test.ts, run.test.ts, workspace.test.ts, cypress-component-tests.test.ts) into smaller, more focused test files. The file
cypress-component-tests-buildable.test.tsis a new file containing test code that was previously part of a larger test suite. -
No changes to Cypress installation or configuration: The PR contains no modifications to:
- Cypress installation logic
- Cypress configuration files
- Package dependencies
- Binary download mechanisms
- Cache handling
-
The test code itself is unchanged: The test implementation in
cypress-component-tests-buildable.test.tsfollows the same patterns as existing Cypress component tests. The logic and test behavior remain the same - only the file structure and organization changed. -
No similar failures detected in other branches: The similar task failure check for branch 33078 returned empty, indicating this is an isolated environmental issue rather than a recurring problem introduced by code changes.
-
CI environment setup issues: The logs show multiple "Cypress was not verified. Installing Cypress now" messages, indicating the CI environment is attempting to install Cypress during test execution because the binary is not cached properly.
This is a typical CI cache configuration issue where the Cypress binary cache is not properly persisted between build steps in the CI pipeline. The failure is completely unrelated to the test-splitting refactoring changes made in this PR.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
| - e2e-ci**module-federation/misc-rspack-interoperability** | ||
| - e2e-ci**module-federation/dynamic-federation.webpack** | ||
| - e2e-ci**docker** | ||
| - e2e-ci**module-federation/misc-rspack-interoperability** | ||
| - e2e-ci**cypress-legacy** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a duplicate entry for 'e2e-cimodule-federation/misc-rspack-interoperability' on lines 42 and 45. One of these entries should be removed to avoid running the same test twice.
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
4bc10c4 to
c00a4a1
Compare
c00a4a1 to
9ec289d
Compare
…ypress
Split the following test suites into smaller, more focused tests:
Fixes CLOUD-3756
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #