Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rarmatei
Copy link
Collaborator

@rarmatei rarmatei commented Oct 8, 2025

…ypress

Split the following test suites into smaller, more focused tests:

  • nx misc tests (cross-workspace, format, global installation, help, migrate, report/list, show)
  • nx run tests (bail, exec, forwarding params, many, one, targets)
  • workspace tests (convert to monorepo, infer targets, move project, npm package, remove project)
  • react cypress component tests (app, async webpack, buildable, lib, vite)
  • react module federation rspack tests (promise-based, var, versions)

Fixes CLOUD-3756

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

…ypress

Split the following test suites into smaller, more focused tests:
- nx misc tests (cross-workspace, format, global installation, help, migrate, report/list, show)
- nx run tests (bail, exec, forwarding params, many, one, targets)
- workspace tests (convert to monorepo, infer targets, move project, npm package, remove project)
- react cypress component tests (app, async webpack, buildable, lib, vite)
- react module federation rspack tests (promise-based, var, versions)
@netlify
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 9ec289d
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/68f2c1470222010008cc97f1
😎 Deploy Preview https://deploy-preview-33009--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel
Copy link

vercel bot commented Oct 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Oct 17, 2025 10:35pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Oct 8, 2025

View your CI Pipeline Execution ↗ for commit 9ec289d

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 42m 23s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 57s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-17 23:11:44 UTC

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

Resolved conflict in e2e/nx/src/misc.test.ts by removing the file as it
was intentionally split into smaller test files in this branch.
Added the new pnpm catalog test that was added to misc.test.ts in
upstream commit e8bd83e to our split misc-migrate.test.ts file.

This includes:
- Updated mock fetcher to handle react, react-dom, and lodash packages
- New test for pnpm catalog references and catalog definition updates
- Import of getSelectedPackageManager from @nx/e2e-utils
@rarmatei rarmatei marked this pull request as ready for review October 17, 2025 11:30
@rarmatei rarmatei requested review from a team as code owners October 17, 2025 11:30
@rarmatei rarmatei requested review from MaxKless and jaysoo October 17, 2025 11:30
Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

This failure is classified as 'environment_state' because:

  1. The error is explicitly a cache/persistence problem: The Cypress binary is missing from the expected cache location /home/workflows/.cache/Cypress/14.5.4/Cypress/Cypress, and the error message directly states "You ran 'npm install' at an earlier build step but did not persist: /home/workflows/.cache/Cypress".

  2. The PR only splits existing test files: This is a test refactoring PR that extracts tests from larger suites (misc.test.ts, run.test.ts, workspace.test.ts, cypress-component-tests.test.ts) into smaller, more focused test files. The file cypress-component-tests-buildable.test.ts is a new file containing test code that was previously part of a larger test suite.

  3. No changes to Cypress installation or configuration: The PR contains no modifications to:

    • Cypress installation logic
    • Cypress configuration files
    • Package dependencies
    • Binary download mechanisms
    • Cache handling
  4. The test code itself is unchanged: The test implementation in cypress-component-tests-buildable.test.ts follows the same patterns as existing Cypress component tests. The logic and test behavior remain the same - only the file structure and organization changed.

  5. No similar failures detected in other branches: The similar task failure check for branch 33078 returned empty, indicating this is an isolated environmental issue rather than a recurring problem introduced by code changes.

  6. CI environment setup issues: The logs show multiple "Cypress was not verified. Installing Cypress now" messages, indicating the CI environment is attempting to install Cypress during test execution because the binary is not cached properly.

This is a typical CI cache configuration issue where the Cypress binary cache is not properly persisted between build steps in the CI pipeline. The failure is completely unrelated to the test-splitting refactoring changes made in this PR.

A code change would likely not resolve this issue, so no action was taken.

Nx CloudView in Nx Cloud ↗


🎓 To learn more about Self Healing CI, please visit nx.dev

@rarmatei rarmatei requested a review from a team as a code owner October 17, 2025 16:01
Comment on lines 42 to 46
- e2e-ci**module-federation/misc-rspack-interoperability**
- e2e-ci**module-federation/dynamic-federation.webpack**
- e2e-ci**docker**
- e2e-ci**module-federation/misc-rspack-interoperability**
- e2e-ci**cypress-legacy**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a duplicate entry for 'e2e-cimodule-federation/misc-rspack-interoperability' on lines 42 and 45. One of these entries should be removed to avoid running the same test twice.

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@rarmatei rarmatei force-pushed the split-remaining-slow-e2e-4 branch from c00a4a1 to 9ec289d Compare October 17, 2025 22:20
@rarmatei rarmatei closed this Oct 24, 2025
@rarmatei rarmatei deleted the split-remaining-slow-e2e-4 branch October 24, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant