fix(misc): handle null exit codes from crashed child processes #33163
+91
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 1184968
☁️ Nx Cloud last updated this comment at |
d4817cb to
a5b04dc
Compare
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We've updated the signalToCode function signature to accept NodeJS.Signals | null instead of just NodeJS.Signals, which resolves the TypeScript compilation error. When the signal is null, the function now returns exit code 1 as a sensible default for crashed processes.
We verified this fix by re-running create-nx-workspace:test.
Suggested Fix changes
diff --git a/packages/create-nx-workspace/src/utils/child-process-utils.ts b/packages/create-nx-workspace/src/utils/child-process-utils.ts
index 9fa3e6cab5..8a508352fb 100644
--- a/packages/create-nx-workspace/src/utils/child-process-utils.ts
+++ b/packages/create-nx-workspace/src/utils/child-process-utils.ts
@@ -60,7 +60,10 @@ export function execAndWait(
});
}
-function signalToCode(signal: NodeJS.Signals): number {
+function signalToCode(signal: NodeJS.Signals | null): number {
+ if (signal === null) {
+ return 1;
+ }
switch (signal) {
case 'SIGHUP':
return 128 + 1;
diff --git a/packages/nx/src/utils/exit-codes.ts b/packages/nx/src/utils/exit-codes.ts
index 309ab8aafc..0f23124ae4 100644
--- a/packages/nx/src/utils/exit-codes.ts
+++ b/packages/nx/src/utils/exit-codes.ts
@@ -2,7 +2,10 @@
* Translates NodeJS signals to numeric exit code
* @param signal
*/
-export function signalToCode(signal: NodeJS.Signals): number {
+export function signalToCode(signal: NodeJS.Signals | null): number {
+ if (signal === null) {
+ return 1;
+ }
switch (signal) {
case 'SIGHUP':
return 128 + 1;
Or Apply changes locally with:
npx nx-cloud apply-locally 4Ns9-rr3U
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 To learn more about Self Healing CI, please visit nx.dev
a5b04dc to
1184968
Compare
Coly010
approved these changes
Oct 22, 2025
MaxKless
approved these changes
Oct 22, 2025
jaysoo
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In some scenarios, when some processes terminate unexpectedly (e.g. crashed due to OOM), the task runner will incorrectly determine their exit code to be 0. This results in Nx storing the task results as a success, which can cause cache hits with false positive successes.
Expected Behavior
When processes terminate unexpectedly (e.g. crashed due to OOM), the task runner should correctly determine their exit code from the signal, and it should never be 0. The stored task result should not be marked as successful.
Related Issue(s)
Fixes #29204