fix(core): invalidate sync generator cache on file changes and use up-to-date project graph #33780
+57
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 0862da5
☁️ Nx Cloud last updated this comment at |
…-to-date project graph
1a12add to
0862da5
Compare
FrozenPandaz
requested changes
Dec 17, 2025
| const { projects } = | ||
| readProjectsConfigurationFromProjectGraph(projectGraph); | ||
| // Fetch the latest graph instead of using the captured one which might be stale | ||
| const { projectGraph: latestGraph, error } = |
Collaborator
There was a problem hiding this comment.
The projectGraph has been used plenty in this function... wouldn't those also be outdated? What is sending this function an outdated graph?
Collaborator
There was a problem hiding this comment.
Nevermind, I get it now
FrozenPandaz
approved these changes
Dec 17, 2025
| const { projects } = | ||
| readProjectsConfigurationFromProjectGraph(projectGraph); | ||
| // Fetch the latest graph instead of using the captured one which might be stale | ||
| const { projectGraph: latestGraph, error } = |
Collaborator
There was a problem hiding this comment.
Nevermind, I get it now
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Sync generators are processed in the background by the daemon server. Their results are cached and reprocessed when the project graph is recomputed. There are currently two issues:
Expected Behavior
Getting sync generators changes should always return up-to-date information.