-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(repo): install nightly Rust for WASM build in publish workflow #33792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The mise migration removed the pre-installed nightly Rust toolchain that was available on ubuntu-latest runners. The WASM build requires nightly Rust because it uses the unstable `wasi_ext` feature. Changes: - Add explicit `rustup toolchain install nightly-2025-12-10` before WASM build - Update build:wasm script from old nightly-2025-05-09 to nightly-2025-12-10 This ensures the nightly toolchain is available before the build script attempts to use it via `rustup override set`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit c37d913
☁️ Nx Cloud last updated this comment at |
…33792) ## Current Behavior After the mise migration (#33772), the `publish.yml` workflow fails during the "Build Wasm" step with: ``` error[E0554]: `#![feature]` may not be used on the stable release channel --> packages/nx/src/lib.rs:2:33 | 2 | #![cfg_attr(target_os = "wasi", feature(wasi_ext))] ``` The WASM build requires nightly Rust because it uses the unstable `wasi_ext` feature. The `build:wasm` script attempts to switch to nightly via `rustup override set`, but after the mise migration, the nightly toolchain is no longer pre-installed, causing the build to fail with the stable compiler. ## Expected Behavior The WASM build should successfully compile using nightly Rust with the `wasi_ext` feature. ## Related Issue(s) Fixes the publish workflow regression introduced in #33772
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
After the mise migration (#33772), the
publish.ymlworkflow fails during the "Build Wasm" step with:The WASM build requires nightly Rust because it uses the unstable
wasi_extfeature. Thebuild:wasmscript attempts to switch to nightly viarustup override set, but after the mise migration, the nightly toolchain is no longer pre-installed, causing the build to fail with the stable compiler.Expected Behavior
The WASM build should successfully compile using nightly Rust with the
wasi_extfeature.Related Issue(s)
Fixes the publish workflow regression introduced in #33772