-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix(misc): use string type for fetchDepth in azure-pipelines.yml #33727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(misc): use string type for fetchDepth in azure-pipelines.yml #33727
Conversation
The Azure Pipelines schema requires fetchDepth to be a string, but the generator was outputting a number. This fix changes the value to a string to match the official schema specification.
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit cd7b676
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
Our analysis determined this is an environment_state issue, not related to the PR changes. The local npm registry at localhost:4873 is missing the has-tostringtag package, causing all tests to fail during workspace creation before the PR's Azure Pipelines YAML changes are even evaluated. The fetchDepth type change (number to string) has no connection to package resolution or registry configuration.
No code changes were suggested for this issue.
If the issue was transient, you can trigger a rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🎓 Learn more about Self-Healing CI on nx.dev
) The Azure Pipelines schema requires fetchDepth to be a string, but the generator was outputting a number. This fix changes the value to a string to match the official schema specification. ## Current Behavior The generator creates `azure-pipelines.yml` with `fetchDepth: 0` (number), which causes YAML schema validation error because the Azure Pipelines schema expects `fetchDepth` to be a string. According to the [Azure Pipelines schema](https://raw.githubusercontent.com/microsoft/azure-pipelines-vscode/master/service-schema.json), `fetchDepth` is defined as: ```json "fetchDepth": { "description": "Depth of Git graph to fetch", "$ref": "#/definitions/string" } ``` ## Expected Behavior The generator should output `fetchDepth: '0'` (string) to match the schema specification and prevent validation errors. Co-authored-by: Jason Jean <[email protected]>
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
The Azure Pipelines schema requires fetchDepth to be a string, but the generator was outputting a number.
This fix changes the value to a string to match the official schema specification.
Current Behavior
The generator creates
azure-pipelines.ymlwithfetchDepth: 0(number), which causes YAML schema validation error because the Azure Pipelines schema expectsfetchDepthto be a string.According to the Azure Pipelines schema,
fetchDepthis defined as:Expected Behavior
The generator should output
fetchDepth: '0'(string) to match the schema specification and prevent validation errors.