fix(core): create all tables upfront when creating the database #33843
+65
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit cf7abf1
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Dec 12, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
Create all the tables upfront when creating the database. This prevents some issues in some scenarios where a missing table is reported. (cherry picked from commit ed09ee1)
FrozenPandaz
added a commit
that referenced
this pull request
Dec 15, 2025
…33874) ## Current Behavior The `linkTaskDetails` parameter was removed from the `NxCache` constructor in #33843, which broke Nx Cloud since it still passes this parameter. ## Expected Behavior The `NxCache` constructor should accept the `linkTaskDetails` parameter (even if unused) to maintain backwards compatibility with Nx Cloud. ## Related Issue(s) Fixes ed09ee1#r172894152
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
Create all the tables upfront when creating the database. This prevents some issues in some scenarios where a missing table is reported.
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
Create all the tables upfront when creating the database. This prevents some issues in some scenarios where a missing table is reported. (cherry picked from commit ed09ee1)
FrozenPandaz
added a commit
that referenced
this pull request
Dec 15, 2025
…33874) ## Current Behavior The `linkTaskDetails` parameter was removed from the `NxCache` constructor in #33843, which broke Nx Cloud since it still passes this parameter. ## Expected Behavior The `NxCache` constructor should accept the `linkTaskDetails` parameter (even if unused) to maintain backwards compatibility with Nx Cloud. ## Related Issue(s) Fixes ed09ee1#r172894152 (cherry picked from commit 2be4dde)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create all the tables upfront when creating the database. This prevents some issues in some scenarios where a missing table is reported.