chore(repo): update nx to 22.4.0-beta.1 #33968
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 7e2f951
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Important
A new CI pipeline execution was requested that may update the conclusion below...
Nx Cloud is proposing a fix for your failed CI:
We updated the test snapshots to reflect the new behavior introduced in Nx 22.4.0-beta.1, where the Cypress configuration generator now adds "moduleResolution": "node10" to tsconfig files. This change fixes the snapshot mismatches in react:test and next:test by aligning the expected output with the actual generated configuration, which includes this field to resolve TypeScript TS5095 compatibility issues with Cypress.
We are verifying this fix by re-running react:test.
Suggested Fix changes
diff --git a/packages/next/src/generators/cypress-component-configuration/cypress-component-configuration.spec.ts b/packages/next/src/generators/cypress-component-configuration/cypress-component-configuration.spec.ts
index 53a18d58f8..9ea89a0a5f 100644
--- a/packages/next/src/generators/cypress-component-configuration/cypress-component-configuration.spec.ts
+++ b/packages/next/src/generators/cypress-component-configuration/cypress-component-configuration.spec.ts
@@ -47,6 +47,7 @@ describe('cypress-component-configuration generator', () => {
"compilerOptions": {
"allowJs": true,
"module": "commonjs",
+ "moduleResolution": "node10",
"outDir": "../dist/out-tsc",
"sourceMap": false,
"types": [
@@ -211,6 +212,7 @@ describe('cypress-component-configuration generator', () => {
"compilerOptions": {
"allowJs": true,
"module": "commonjs",
+ "moduleResolution": "node10",
"outDir": "../dist/out-tsc",
"sourceMap": false,
"types": [
diff --git a/packages/react/src/generators/application/application.spec.ts b/packages/react/src/generators/application/application.spec.ts
index 7b375ac238..334478eb6c 100644
--- a/packages/react/src/generators/application/application.spec.ts
+++ b/packages/react/src/generators/application/application.spec.ts
@@ -331,6 +331,7 @@ describe('app', () => {
"compilerOptions": {
"allowJs": true,
"module": "commonjs",
+ "moduleResolution": "node10",
"outDir": "../dist/out-tsc",
"sourceMap": false,
"types": [
Or Apply changes locally with:
npx nx-cloud apply-locally 6mxH-WxX4
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Updating Nx from 22.3.0-beta.3 to 22.4.0-beta.1