feat(core): add preferBatch executor option #34293
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit e67b5f1
☁️ Nx Cloud last updated this comment at |
97d26d5 to
c5dca78
Compare
45c979f to
aff4f00
Compare
aff4f00 to
b01cc68
Compare
b01cc68 to
f1ff4ed
Compare
f1ff4ed to
f7ad4f3
Compare
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
36d8da9 to
6ef956f
Compare
Add a `preferBatch` property to executor configuration that allows plugin authors to indicate their executor should use batch mode by default, while still allowing users to opt-out with --no-batch. Behavior: - --batch flag: batch everything - --no-batch flag: batch nothing - not specified: use each executor's preferBatch preference Enable preferBatch for gradle and maven executors since they benefit most from batch execution.
6ef956f to
0b57741
Compare
Add a `preferBatch` property to executor configuration that allows plugin authors to indicate their executor should use batch mode by default, while still allowing users to opt-out with --no-batch. Behavior: - --batch flag: batch everything - --no-batch flag: batch nothing - not specified: use each executor's preferBatch preference Enable preferBatch for gradle and maven executors since they benefit most from batch execution. [Self-Healing CI Rerun]
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🎓 Learn more about Self-Healing CI on nx.dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Batch mode is binary:
--batchflag → batch ALL executors that support itThis means users of gradle/maven must always remember to pass
--batchto get the performance benefits.Expected Behavior
Plugin authors can now set
preferBatch: truein their executor config to indicate batch mode should be used by default. Users can still opt-out with--no-batch.Three states:
--batch→ batch everything--no-batch→ batch nothingpreferBatchpreference--batchflagpreferBatchtruefalsetruefalse/undefinedChanges
preferBatch?: booleantoExecutorJsonEntryConfigandExecutorConfiginterfaces--batchdefault fromfalsetoundefinedto allowpreferBatchto decidepreferBatchpreferBatch: truefor gradle and maven executorspreferBatchscenariosRelated Issue(s)