Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(react): remove file-loader dependency and update svgr migration#34218

Merged
Coly010 merged 1 commit intomasterfrom
fix-webpack-5-loader
Jan 26, 2026
Merged

fix(react): remove file-loader dependency and update svgr migration#34218
Coly010 merged 1 commit intomasterfrom
fix-webpack-5-loader

Conversation

@Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jan 26, 2026

Current Behavior

The migration for svgr requires using file-loader which is unmaintained.

Expected Behavior

Use asset/resource instead of file-loader

Related Issue(s)

CLOSES NXC-3667

@Coly010 Coly010 requested review from a team as code owners January 26, 2026 13:37
@Coly010 Coly010 requested a review from JamesHenry January 26, 2026 13:37
@Coly010 Coly010 self-assigned this Jan 26, 2026
@Coly010 Coly010 requested a review from jaysoo January 26, 2026 13:37
@vercel
Copy link

vercel bot commented Jan 26, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Jan 26, 2026 1:47pm

Request Review

@netlify
Copy link

netlify bot commented Jan 26, 2026 •
edited
Loading

✅ Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 7557fdc
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69776ecce048ca00080a9d72
😎 Deploy Preview https://deploy-preview-34218--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Jan 26, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 7557fdc

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 32m 56s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3m 11s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-26 14:18:51 UTC

@Coly010 Coly010 force-pushed the fix-webpack-5-loader branch from 66bcaac to 7557fdc Compare January 26, 2026 13:40
@Coly010 Coly010 requested a review from a team as a code owner January 26, 2026 13:40
@Coly010 Coly010 merged commit 3fcd200 into master Jan 26, 2026
20 checks passed
@Coly010 Coly010 deleted the fix-webpack-5-loader branch January 26, 2026 16:56
FrozenPandaz pushed a commit that referenced this pull request Jan 26, 2026
@Coly010 @FrozenPandaz
fix(react): remove file-loader dependency and update svgr migration (#…
eb239f3 
…34218)

## Current Behavior
The migration for svgr requires using file-loader which is unmaintained.

## Expected Behavior
Use asset/resource instead of file-loader

## Related Issue(s)

CLOSES NXC-3667

(cherry picked from commit 3fcd200)
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jaysoo jaysoo jaysoo approved these changes

@leosvelperez leosvelperez leosvelperez approved these changes

@JamesHenry JamesHenry Awaiting requested review from JamesHenry JamesHenry is a code owner automatically assigned from nrwl/nx-linter-reviewers

Assignees

@Coly010 Coly010

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Coly010 @jaysoo @leosvelperez