Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(core): make sure that mcp args aren't overridden when running configure-ai-agents#34381

Merged
MaxKless merged 1 commit intomasterfrom
caia-mcp-flags-noop
Feb 10, 2026
Merged

fix(core): make sure that mcp args aren't overridden when running configure-ai-agents#34381
MaxKless merged 1 commit intomasterfrom
caia-mcp-flags-noop

Conversation

@MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Feb 9, 2026 •
edited
Loading

Current Behavior

right now if users modify their mcp params like --minimal, we will override them on configure-ai-agents

Expected Behavior

We want to bring users up to latest without overriding their valid configurations

@MaxKless MaxKless requested a review from a team as a code owner February 9, 2026 17:15
@MaxKless MaxKless requested a review from AgentEnder February 9, 2026 17:15
@netlify
Copy link

netlify bot commented Feb 9, 2026 •
edited
Loading

✅ Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 77e5928
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/698b244ad8b06300087428f6
😎 Deploy Preview https://deploy-preview-34381--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 9, 2026 •
edited
Loading

✅ Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 77e5928
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/698b244ab666790008d4af24
😎 Deploy Preview https://deploy-preview-34381--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Feb 10, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 77e5928

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 44m 28s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3m 55s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 7s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-10 13:16:57 UTC

@MaxKless MaxKless force-pushed the caia-mcp-flags-noop branch from 62a7466 to 77e5928 Compare February 10, 2026 12:27
@MaxKless MaxKless enabled auto-merge (squash) February 10, 2026 12:37
@MaxKless MaxKless merged commit 5066511 into master Feb 10, 2026
24 checks passed
@MaxKless MaxKless deleted the caia-mcp-flags-noop branch February 10, 2026 13:24
FrozenPandaz pushed a commit that referenced this pull request Feb 13, 2026
@MaxKless @FrozenPandaz
fix(core): make sure that mcp args aren't overridden when running con…
3badb93 
…figure-ai-agents (#34381)

## Current Behavior
right now if users modify their mcp params like `--minimal`, we will
override them on `configure-ai-agents`

## Expected Behavior
We want to bring users up to latest without overriding their valid
configurations

(cherry picked from commit 5066511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leosvelperez leosvelperez leosvelperez approved these changes

@Coly010 Coly010 Coly010 approved these changes

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner automatically assigned from nrwl/nx-core-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxKless @leosvelperez @Coly010