fix(node): add srcRootForCompilationRoot option for node package builder#3564
Merged
FrozenPandaz merged 1 commit intonrwl:masterfrom Aug 19, 2020
Merged
fix(node): add srcRootForCompilationRoot option for node package builder#3564FrozenPandaz merged 1 commit intonrwl:masterfrom
FrozenPandaz merged 1 commit intonrwl:masterfrom
Conversation
c225879 to
d91165f
Compare
Doginal
pushed a commit
to Doginal/nx
that referenced
this pull request
Nov 25, 2020
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
WIth the recent changes to the tsconfig.lib.json for the node:package builder, rootDir was removed. There is no way for users to specify the rootDir.
Expected Behavior
a new property is added (
srcRootForCompilationRoot). A migration also checks if the user already had a rootDir and creates the property for them in the workspace/angular.jsonRelated Issue(s)
Fixes #