Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(linter): add root .eslintrc.json to implicit deps#3852

Merged
FrozenPandaz merged 2 commits intonrwl:masterfrom
JamesHenry:add-eslintrc-json-to-implicit-deps
Oct 2, 2020
Merged

fix(linter): add root .eslintrc.json to implicit deps#3852
FrozenPandaz merged 2 commits intonrwl:masterfrom
JamesHenry:add-eslintrc-json-to-implicit-deps

Conversation

@JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented Oct 2, 2020

Current Behavior

Changes to the root ESLint config will not cause any projects to be affected

Expected Behavior

"All" projects should be - i.e. the behaviour should be the same as with TSLint

Related Issue(s)

Fixes #2858

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Oct 2, 2020

Nx Cloud Report

CI ran the following commands for commit 7f43ff6. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx build-base express 10/2/2020, 10:17:17 AM
#000000 nx build-base nest 10/2/2020, 10:17:17 AM
#000000 nx build-base next 10/2/2020, 10:17:19 AM
#000000 nx build-base react 10/2/2020, 10:17:17 AM
#000000 nx run-many --target=build --all --parallel 10/2/2020, 10:17:01 AM
#000000 nx run-many --target=e2e --projects=e2e-angular,e2e-bazel 10/2/2020, 10:16:14 AM
#000000 nx run-many --target=e2e --projects=e2e-cypress,e2e-jest,e2e-nx-plugin 10/2/2020, 10:17:12 AM
#000000 nx run-many --target=e2e --projects=e2e-next 10/2/2020, 10:17:29 AM
#000000 nx run-many --target=e2e --projects=e2e-node 10/2/2020, 10:17:14 AM
#000000 nx run-many --target=e2e --projects=e2e-react 10/2/2020, 10:17:25 AM
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-linter,e2e-storybook 10/2/2020, 10:17:14 AM
#000000 nx run-many --target=e2e --projects=e2e-workspace,e2e-cli 10/2/2020, 10:16:13 AM
#000000 nx run-many --target=lint --all --parallel 10/2/2020, 10:17:15 AM

Sent with 💌 from NxCloud.

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@FrozenPandaz FrozenPandaz merged commit da6f987 into nrwl:master Oct 2, 2020
Doginal pushed a commit to Doginal/nx that referenced this pull request Nov 25, 2020
* fix(linter): add root .eslintrc.json to implicit deps

* fix(linter): unit tests
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

updating .eslintrc doesn't invalidate the cache

2 participants