Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@o-ga09
Copy link
Owner

@o-ga09 o-ga09 commented Jun 3, 2024

close #

実装内容

  • BGM検索

動作確認

  • テストが通ること
  • scenarigoによるE2Eテストが通ること

エビデンス

テスト結果

}}); err != nil {
connect(dialector, 100)
}
db.AutoMigrate(&Monster{}, &Field{}, &Product{}, &Tribe{}, &Weakness{}, &Ranking{}, &Music{}, &BgmRanking{})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Error return value of db.AutoMigrate is not checked (errcheck)

})
}

for _, m := range r {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
unnecessary leading newline (whitespace)

id = ""
}

ctx := context.WithValue(c.Request.Context(), "param", param)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)

id = ""
}

ctx := context.WithValue(c.Request.Context(), "param", param)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)

return
}

ctx := context.WithValue(c.Request.Context(), "param", param)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)

}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
ctx = context.WithValue(context.Background(), "param", tt.args.param)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)

}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
ctx = context.WithValue(context.Background(), "param", tt.args.param)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)

@o-ga09 o-ga09 force-pushed the feature/search-bgm branch from 4c2e07e to 619cbe5 Compare June 4, 2024 12:47
@o-ga09 o-ga09 merged commit 0f309a2 into main Jun 4, 2024
@o-ga09 o-ga09 deleted the feature/search-bgm branch June 4, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants