-
Notifications
You must be signed in to change notification settings - Fork 0
✨ BGM検索 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ BGM検索 #81
Conversation
| }}); err != nil { | ||
| connect(dialector, 100) | ||
| } | ||
| db.AutoMigrate(&Monster{}, &Field{}, &Product{}, &Tribe{}, &Weakness{}, &Ranking{}, &Music{}, &BgmRanking{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Error return value of db.AutoMigrate is not checked (errcheck)
| }) | ||
| } | ||
|
|
||
| for _, m := range r { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
unnecessary leading newline (whitespace)
| id = "" | ||
| } | ||
|
|
||
| ctx := context.WithValue(c.Request.Context(), "param", param) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
| id = "" | ||
| } | ||
|
|
||
| ctx := context.WithValue(c.Request.Context(), "param", param) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
| return | ||
| } | ||
|
|
||
| ctx := context.WithValue(c.Request.Context(), "param", param) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| ctx = context.WithValue(context.Background(), "param", tt.args.param) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| ctx = context.WithValue(context.Background(), "param", tt.args.param) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
4c2e07e to
619cbe5
Compare
close #
実装内容
動作確認
テスト結果