[FEATURE] - deprecate read/write in favor of read_one/read_many/write_one/write_many#307
Draft
Josh-2 wants to merge 1 commit intoottowayi:devfrom
Draft
[FEATURE] - deprecate read/write in favor of read_one/read_many/write_one/write_many#307Josh-2 wants to merge 1 commit intoottowayi:devfrom
Josh-2 wants to merge 1 commit intoottowayi:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Feature Request
Feature Description
I was planning on proposing overloads (see below) for
readandwritebut:Instead I am proposing the following changes.
Proposed Changes
readandwritemethods intoread_one,read_many,write_one, andwrite_manyreadandwriteand update calls to useread_manyandwrite_manywhile maintaining their existing functionalityI believe this change improves the readability and predictability of the code by making it clear what type each method will return.
@ottowayi I realize this is a very opinionated proposal. Is this something that you're interested in?