Add additional_model_kwargs and additional_trainer_kwargs to train function #1624
+19
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
trainfunction and related methods in theoumimodule to support additional model and trainer keyword arguments. The motivation was to allow passing non-serializable keyword arguments into the trainer class (and the model class). The most important changes are as follows:Enhancements to
trainfunction:trainfunction insrc/oumi/__init__.pyto acceptadditional_model_kwargsandadditional_trainer_kwargsparameters and pass them to theoumi.train.trainfunction.Enhancements to
trainfunction insrc/oumi/train.py:_create_optional_training_kwargsfunction to accept anadditional_trainer_kwargsparameter and include it in the returned dictionary. [1] [2]trainfunction to acceptadditional_model_kwargsandadditional_trainer_kwargsparameters and use them when building the model and creating optional training kwargs. [1] [2]Related issues
Fixes #1623 by allowing user to pass a
preprocess_logits_for_metricsfunction toadditional_trainer_kwargsin thetrainfunction.Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.