Support custom processor args in ModelParams
#1634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
processor args in ModelParamsprocessor args in ModelParams
taenin
approved these changes
Apr 14, 2025
wizeng23
approved these changes
Apr 14, 2025
| Processors are used in Oumi for vision-language models to process image and | ||
| text inputs. This field is optional and can be left empty for text-only models, | ||
| or if not needed. |
There was a problem hiding this comment.
nit: consider mentioning that they'll override model-specific default values for these kwargs, if present.
| raise ValueError( | ||
| "processor_kwargs attempts to override the following " | ||
| f"reserved fields: {conflicting_keys}. " | ||
| "Use properties of ModelParams instead." |
There was a problem hiding this comment.
As far as I can tell, is trust_remote_code the only ModelParams property which is used in processor creation? Is there a chance of any false errors here, where a kwarg key conflicts with a ModelParams property, but that property isn't used in processor creation?
There was a problem hiding this comment.
This validation logic is a bit inexact but should work in practice (we can always modify it if it something unexpected happens )
This is also based on two existing precedents: https://github.com/search?q=repo%3Aoumi-ai%2Foumi%20conflicting_keys&type=code
penfever
pushed a commit
that referenced
this pull request
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-- Update
ModelParamsto includeprocessor_args-- Update
build_processor()and most of its invocations, exceptvision_language_conversation_feature_generator.py, which will be handled as a follow-up (it's a more involved change)Related issues
Towards OPE-1185
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.