Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Remote Inference] Error checking for api_key #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

[Remote Inference] Error checking for api_key #1638

merged 2 commits into from
Apr 16, 2025

Conversation

@kaisopos
Copy link
Contributor

@kaisopos kaisopos commented Apr 16, 2025 •
edited
Loading

Description

Changes

  • Do NOT include the AUTH BEARER header in the request, if API KEY is NOT available
  • Fast fail if the API KEY is NOT available but required (api_key_env_varname is set)

Related issues

Fixes N/A

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@kaisopos kaisopos requested a review from taenin April 16, 2025 05:45
taenin
taenin approved these changes Apr 16, 2025
View reviewed changes
@kaisopos kaisopos merged commit 50b8b09 into main Apr 16, 2025
2 checks passed
@kaisopos kaisopos deleted the kostas/inference_api_key_error_checking branch April 16, 2025 16:37
georgedouzas pushed a commit to georgedouzas/oumi that referenced this pull request Apr 18, 2025
@kaisopos @georgedouzas
[Remote Inference] Error checking for api_key (oumi-ai#1638)
d963d31
penfever pushed a commit that referenced this pull request Aug 27, 2025
@kaisopos
[Remote Inference] Error checking for api_key (#1638)
cac0b7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taenin taenin taenin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaisopos @taenin