Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add configs for molmo support #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 3, 2025
Merged

Add configs for molmo support #1710

merged 8 commits into from
Jun 3, 2025

Conversation

@oelachqar
Copy link
Contributor

Description

  • Add configs for molmo support (internal config, chat template, train config)
  • Add more documentation to the internal config code

Related issues

Fixes # (issue)

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

wizeng23
wizeng23 approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@wizeng23 wizeng23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider waiting for Nikolai's review of the added code comments; I don't have the context needed to verify them

@oelachqar oelachqar merged commit 10463f3 into main Jun 3, 2025
5 checks passed
@oelachqar oelachqar deleted the oelachqar/add_molmo branch June 3, 2025 15:56
penfever pushed a commit that referenced this pull request Aug 27, 2025
@oelachqar
Add configs for molmo support (#1710)
69ff999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wizeng23 wizeng23 wizeng23 approved these changes

@nikg4 nikg4 Awaiting requested review from nikg4

@taenin taenin Awaiting requested review from taenin

@jgreer013 jgreer013 Awaiting requested review from jgreer013

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oelachqar @wizeng23