Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[tiny] fix pre-commits checks on a fresh install #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

[tiny] fix pre-commits checks on a fresh install #1711

merged 2 commits into from
Jun 3, 2025

Conversation

@oelachqar
Copy link
Contributor

Description

  • alpaca_eval is an optional dependency, and if not installed users will get a type check error
  • This PR adds the proper type ignore to mitigate the issue (not the most elegant fix, open to suggestions)

Related issues

Fixes # (issue)

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

wizeng23
wizeng23 reviewed Jun 3, 2025
View reviewed changes
Copy link
Contributor

@wizeng23 wizeng23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why it isn't an issue for vllm here: https://github.com/oumi-ai/oumi/blob/main/src/oumi/inference/vllm_inference_engine.py

Is it because Alpaca's code has type checking?

@oelachqar
Copy link
Contributor Author

Any idea why it isn't an issue for vllm here: https://github.com/oumi-ai/oumi/blob/main/src/oumi/inference/vllm_inference_engine.py

Is it because Alpaca's code has type checking?

Updated with a similar approach -- much better!

@oelachqar oelachqar merged commit ae92cb2 into main Jun 3, 2025
5 checks passed
@oelachqar oelachqar deleted the oelachqar/fix_fresh_install branch June 3, 2025 16:28
penfever pushed a commit that referenced this pull request Aug 27, 2025
@oelachqar
[tiny] fix pre-commits checks on a fresh install (#1711)
497f5ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wizeng23 wizeng23 wizeng23 left review comments

@kaisopos kaisopos kaisopos approved these changes

@taenin taenin Awaiting requested review from taenin

+1 more reviewer

@nikg4 nikg4 nikg4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oelachqar @wizeng23 @kaisopos @nikg4