Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[tiny][bug] Add missing molmo feature #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2025
Merged

[tiny][bug] Add missing molmo feature #1731

merged 2 commits into from
Jun 5, 2025

Conversation

@oelachqar
Copy link
Contributor

Description

  • Add missing molmo feature attention_mask with InternalFeatureFirstDimAction.KEEP

Related issues

Fixes # (issue)

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@oelachqar oelachqar marked this pull request as ready for review June 5, 2025 19:39
@oelachqar oelachqar merged commit edff99e into main Jun 5, 2025
5 checks passed
@oelachqar oelachqar deleted the ouelachq/add_missing_feature branch June 5, 2025 20:02
penfever pushed a commit that referenced this pull request Aug 27, 2025
@oelachqar
[tiny][bug] Add missing molmo feature (#1731)
11a25b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penfever penfever penfever approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oelachqar @penfever