Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[tiny] Fix gradient checkpointing for Oumi trainer #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2025
Merged

[tiny] Fix gradient checkpointing for Oumi trainer #1778

merged 3 commits into from
Jun 21, 2025

Conversation

@wizeng23
Copy link
Contributor

Description

The current code fails for PEFT models, which also expose a gradient_checkpointing_enable() function. This PR makes the check less strict.

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

@wizeng23 wizeng23 requested a review from oelachqar June 20, 2025 23:43
@wizeng23 wizeng23 merged commit 1a6534d into main Jun 21, 2025
5 checks passed
@wizeng23 wizeng23 deleted the wizeng23-patch-1 branch June 21, 2025 00:11
penfever pushed a commit that referenced this pull request Aug 27, 2025
@wizeng23
[tiny] Fix gradient checkpointing for Oumi trainer (#1778)
ec35373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oelachqar oelachqar oelachqar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wizeng23 @oelachqar