Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed issue with final conversations not consistently being saved #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2025
Merged

Fixed issue with final conversations not consistently being saved #1795

merged 3 commits into from
Jul 2, 2025
+122 −19

Conversation

@jgreer013
Copy link
Contributor

@jgreer013 jgreer013 commented Jul 2, 2025 •
edited
Loading

Description

Conversations were not being saved in the core public infer() method, resulting in some scenarios where only some of the conversations were being written in the case where inference was stopped and restarted, rather than ALL conversations.

Related issues

Towards OPE-1307

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@jgreer013 jgreer013 requested a review from taenin July 2, 2025 17:51
taenin
taenin approved these changes Jul 2, 2025
View reviewed changes
Copy link
Collaborator

@taenin taenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to add / update any tests for the non-remote engines?

@jgreer013
Copy link
Contributor Author

Do you need to add / update any tests for the non-remote engines?

The core issue was with the restart logic which is only held within the base_inference_engine, the new test changes should properly validate that final output files are written and contain all examples, not just those we ran inference on in the latest try.

@jgreer013 jgreer013 merged commit 3e0f3f7 into main Jul 2, 2025
5 checks passed
@jgreer013 jgreer013 deleted the jgreer013/inference-write-bug branch July 2, 2025 21:44
penfever pushed a commit that referenced this pull request Aug 27, 2025
@jgreer013
Fixed issue with final conversations not consistently being saved (#1795
1c73110 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taenin taenin taenin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgreer013 @taenin