Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rlehman221
Copy link
Contributor

@rlehman221 rlehman221 commented Aug 18, 2025

Description

We want to make users more aware that when they run into any types of issues they should open an issue. This PR appends a pre-populated Github issue link after any type of failure occurs for the user to optionally open if they feel it should be tracked by the team.

Example: oumi launch up -c configs/examples/grpo_verl_countdown/gcp_job.yaml --cluster grpo-verl-countdown
BEFORE CHANGES
image

AFTER CHANGERS
Screenshot 2025-08-19 at 10 23 32 AM
Screenshot 2025-08-20 at 9 22 05 AM

LONGER ERROR EXAMPLE
Screenshot 2025-08-20 at 9 21 05 AM
Screenshot 2025-08-20 at 9 21 27 AM

NOTE: For any jobs used with the launcher, rich console logs that leverage links won't work. Instead a check is made and if its a remote job we just display the template for the user to use instead of populating any fields

Screenshot 2025-08-20 at 11 15 19 AM

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

@rlehman221 rlehman221 requested review from taenin and wizeng23 August 18, 2025 22:31
@rlehman221 rlehman221 marked this pull request as draft August 18, 2025 22:33
@taenin taenin requested a review from shanghongsim August 18, 2025 22:40
@rlehman221 rlehman221 marked this pull request as ready for review August 19, 2025 14:30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the error in your PR description (you need to run wandb login) and run again? I'd like to see an example of what it looks like with a more complex bug that has a very large traceback. If you could also copy the created github issue link to the description as well, that'd be great, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we use wandb for?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For experiment tracking. It's like cloud Tensorboard

@rlehman221 rlehman221 linked an issue Aug 20, 2025 that may be closed by this pull request
@rlehman221 rlehman221 self-assigned this Aug 20, 2025
@rlehman221 rlehman221 merged commit 3aff0b4 into main Aug 20, 2025
5 checks passed
@rlehman221 rlehman221 deleted the rlehman/logging_issues branch August 20, 2025 18:07
penfever pushed a commit that referenced this pull request Aug 27, 2025
Co-authored-by: Ryan Lehman <[email protected]>
Co-authored-by: Ryan Lehman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] User friendly exception handling + GH issue filing CTA

3 participants