Add The Ability To Trail Logs For Launcher Jobs #1951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind updating |
wizeng23
reviewed
Aug 25, 2025
wizeng23
reviewed
Aug 26, 2025
There was a problem hiding this comment.
For testing, could you try running the slurm, local, and sky clusters? Example local cluster at "notebooks/Oumi - A Tour.ipynb". For these tests, it would be good to confirm that the logs display properly (ex. for Slurm, logs that are colored text should still have color)
Co-authored-by: William Zeng <[email protected]>
wizeng23
approved these changes
Aug 26, 2025
shanghongsim
approved these changes
Aug 27, 2025
taenin
requested changes
Aug 27, 2025
wizeng23
reviewed
Aug 28, 2025
taenin
approved these changes
Aug 28, 2025
wizeng23
reviewed
Aug 28, 2025
wizeng23
reviewed
Aug 28, 2025
|
Could you keep the PR description updated with the latest status on how the PR works, any issues with it, etc.? |
wizeng23
reviewed
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently have built-in support from SkyPilot for trailing logs through their SDK after launching a job. We want to extend this functionality to our other clusters as well.
This PR adds support for Slurm clusters by tailing the log file and streaming its contents directly to the user’s terminal. For clusters not covered in this PR, the behavior will remain unchanged and continue to show the loading spinner.
Features Added:
BEFORE With Slurm
AFTER With Slurm
AFTER With Sky Pilot
After With Local Cluster
Related issues
Towards OPE-1344
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.