Make stdout_file optional in slurm client #1974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ryan.lehman <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: ryan.lehman <[email protected]>
Co-authored-by: ryan.lehman <[email protected]>
Co-authored-by: ryan.lehman <[email protected]>
Co-authored-by: ryan.lehman <[email protected]>
wizeng23
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the type annotation for the
stdout_fileparameter inSlurmClient.submit_jobfromstrtoOptional[str]. This change correctly reflects that the parameter can beNone, aligning with other optional parameters in the method signature.Related issues
Fixes #OPE-1555
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.Linear Issue: OPE-1555