Add make target to format source code#848
Merged
yesnault merged 11 commits intoovh:masterfrom May 5, 2025
Merged
Conversation
Signed-off-by: Tiago Peczenyj <[email protected]>
…om/ovh/venom/cmd.Exit" Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
f44135b to
a5162c5
Compare
Contributor
Author
Sure @yesnault BTW If you decided to migrate to golangci lint v2, it also handle formatting using not only gofmt but gofumpt and others, so with one dependency you can do linting and formatting. and there is a migrate command to help the transition. |
yesnault
approved these changes
May 5, 2025
peczenyj
added a commit
to peczenyj/venom
that referenced
this pull request
May 7, 2025
* apply go fix ./... Signed-off-by: Tiago Peczenyj <[email protected]> * fix go vet -all issue "non-constant format string in call to github.com/ovh/venom/cmd.Exit" Signed-off-by: Tiago Peczenyj <[email protected]> * run gofmt -e -l -s -w . Signed-off-by: Tiago Peczenyj <[email protected]> * run gofumpt -l -w . Signed-off-by: Tiago Peczenyj <[email protected]> * run gofumpt -l -w -extra . Signed-off-by: Tiago Peczenyj <[email protected]> * run goimports Signed-off-by: Tiago Peczenyj <[email protected]> * add make fmt Signed-off-by: Tiago Peczenyj <[email protected]> * Revert "run gofumpt -l -w -extra ." This reverts commit 8f27a6a. * remove gofumpt --------- Signed-off-by: Tiago Peczenyj <[email protected]> Co-authored-by: Yvonnick Esnault <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
ceriath
pushed a commit
to ceriath/venom
that referenced
this pull request
Jul 11, 2025
* apply go fix ./... Signed-off-by: Tiago Peczenyj <[email protected]> * fix go vet -all issue "non-constant format string in call to github.com/ovh/venom/cmd.Exit" Signed-off-by: Tiago Peczenyj <[email protected]> * run gofmt -e -l -s -w . Signed-off-by: Tiago Peczenyj <[email protected]> * run gofumpt -l -w . Signed-off-by: Tiago Peczenyj <[email protected]> * run gofumpt -l -w -extra . Signed-off-by: Tiago Peczenyj <[email protected]> * run goimports Signed-off-by: Tiago Peczenyj <[email protected]> * add make fmt Signed-off-by: Tiago Peczenyj <[email protected]> * Revert "run gofumpt -l -w -extra ." This reverts commit 8f27a6a. * remove gofumpt --------- Signed-off-by: Tiago Peczenyj <[email protected]> Co-authored-by: Yvonnick Esnault <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add an optional make target
fmtthat runsgofmt,gofumptandgoimportsthis helps to ensure a minimal code standard
I split each run in a separated commit
also I fix one
go vetissue on twocmd.Exitcalls