fix(api): get projects from provider with username#4916
Merged
Conversation
sguiheux
approved these changes
Jan 24, 2020
yesnault
approved these changes
Jan 24, 2020
richardlt
reviewed
Jan 24, 2020
|
|
||
| pKeys := projects.Keys() | ||
| perms, err := permission.LoadProjectMaxLevelPermission(ctx, api.mustDB(), pKeys, getAPIConsumer(ctx).GetGroupIDs()) | ||
| perms, err := permission.LoadProjectMaxLevelPermission(ctx, api.mustDB(), pKeys, groupIDs) |
Member
There was a problem hiding this comment.
Looks like this code is useful only if withPermission, also maintainer an admin can have no permission on project based on groups but we should add read permission for maintainer and all permissions for admin.
Member
Author
There was a problem hiding this comment.
We always need permission. BWT i fixed it for admin, and maintainer permissions
| } | ||
|
|
||
| pKeys := projects.Keys() | ||
| perms, err := permission.LoadProjectMaxLevelPermission(ctx, api.mustDB(), pKeys, getAPIConsumer(ctx).GetGroupIDs()) |
richardlt
approved these changes
Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ovh/cds