feat(api): basic support for openid-connect authentication provider#5393
Merged
sguiheux merged 8 commits intoovh:masterfrom Aug 27, 2020
phsym:auth_oidc
Merged
feat(api): basic support for openid-connect authentication provider#5393sguiheux merged 8 commits intoovh:masterfrom phsym:auth_oidc
sguiheux merged 8 commits intoovh:masterfrom
phsym:auth_oidc
Conversation
This enables basic integration with openid-connect authentication providers like Keycloak or Hydra Signed-off-by: phsym <[email protected]>
phsym
commented
Aug 25, 2020
Handle OIDC driver initialization error Signed-off-by: phsym <[email protected]>
Member
|
Hi, thanks for the PR can you provide some tips about how you test it ? |
Contributor
Author
|
Hi, sure ! I just updated the PR description with the tips |
Member
Contributor
Author
|
@yesnault Done by merging your branch into mine, but it messed up the DCO check for some reason
|
Signed-off-by: Yvonnick Esnault <[email protected]> Signed-off-by: phsym <[email protected]>
Signed-off-by: phsym <[email protected]>
Contributor
Author
|
Oops sorry, I missclicked on close |
Signed-off-by: phsym <[email protected]>
Contributor
Author
|
I just added a check on the "email_verified" OIDC claim |
fsamin
requested changes
Aug 26, 2020
Member
fsamin
left a comment
There was a problem hiding this comment.
Thank you very much to your great contribution. Here are some change requests.
Signed-off-by: phsym <[email protected]>
Contributor
Author
|
@fsamin Corrections provided based on your comments |
yesnault
approved these changes
Aug 26, 2020
fsamin
requested changes
Aug 26, 2020
Member
fsamin
left a comment
There was a problem hiding this comment.
I added 2 suggestions following https://github.com/golang/go/wiki/CodeReviewComments#error-strings
Signed-off-by: phsym <[email protected]>
Contributor
Author
|
@fsamin Done |
richardlt
approved these changes
Aug 26, 2020
sguiheux
approved these changes
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enables basic integration with openid-connect authentication providers like Keycloak or Hydra
About tests
Not sure yet how to automate the tests here, but for manual testing :
docker run -p 4040:8080 -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=admin quay.io/keycloak/keycloak:11.0.1@ovh/cds
Signed-off-by: phsym [email protected]