Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(hooks, api): manage entities hook#6219

Merged
yesnault merged 27 commits intomasterfrom
hookTmp
Jul 5, 2022
Merged

feat(hooks, api): manage entities hook#6219
yesnault merged 27 commits intomasterfrom
hookTmp

Conversation

@sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Jun 28, 2022

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

sguiheux added 21 commits June 10, 2022 15:44
@sguiheux
feat(api): add reopsitory on project
4712a0f
@sguiheux
feat(vcs): start add gitea implementation
4442dbb
@sguiheux
ci: add it
ddc9c17
@sguiheux
chore: merge with master
da4980e
@sguiheux
fix(api): avoid import cycles rbac -> assets -> rbac
0ea8f77
@sguiheux
test: fix gitea host when using docker compose
5b67512
@sguiheux
test: fix gitea host when using docker compose
a975439
@sguiheux
fix: venom step
9bfd7e2
@sguiheux
feat: start vcs on docker compose
db95caa
@sguiheux
fix: test args file
eb07a75
@sguiheux
fix: code review
b63367f
@sguiheux
fix: use identifier instead of name
781f79c
@sguiheux
feat(hook): add route to manage entities hooks
0ef0071
@sguiheux
feat(api,hook): add hook synchronization
20d5c9c
@sguiheux
feat(hooks): add header vcs type
1e06d57
@sguiheux
feat: export vcs type in sdk
bc44464
@sguiheux
fix(hook): save lowercase keys
2f2b49c
@sguiheux
chore: merge with master
4d27281
@sguiheux
fix: comment
f1f061f
@sguiheux
fix: revert os-ansible-inventory
59b88af
@sguiheux
fix: add gitignore
de6ca9d
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 28, 2022

CDS Report build-all-cds#17554.0 ■

  • Build
    • Build and Package All ■
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ■
    • Test SDK ✔
    • Test UI ✔

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 28, 2022

CDS Report build-all-cds#17554.0 ■

  • Build
    • Build and Package All ■
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ■
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 28, 2022

CDS Report build-all-cds#17554.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 28, 2022

CDS Report build-all-cds#17554.2 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 28, 2022

CDS Report build-all-cds#17556.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✘
    • Standalone Tests ✘

fsamin
fsamin requested changes Jul 4, 2022
View reviewed changes
engine/hooks/hooks_handlers.go
}
}

func (s *Service) repositoryHooksHandler() service.Handler {
Copy link
Member

@fsamin fsamin Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/repository/entity

Copy link
Collaborator Author

@sguiheux sguiheux Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handler to receive hook from repository, so i think it's ok

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 4, 2022

CDS Report build-all-cds#17597.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✘
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 4, 2022

CDS Report build-all-cds#17598.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✘
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 4, 2022

CDS Report build-all-cds#17598.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✘
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 4, 2022

CDS Report build-all-cds#17599.0 ■

  • Build
    • Build and Package All ■
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✘
    • Test UI ✔

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 4, 2022

CDS Report build-all-cds#17599.0 ■

  • Build
    • Build and Package All ■
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✘
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 5, 2022

CDS Report build-all-cds#17606.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

53.6% 53.6% Coverage
2.1% 2.1% Duplication

@yesnault yesnault merged commit deb7167 into master Jul 5, 2022
@sguiheux sguiheux deleted the hookTmp branch July 11, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin fsamin approved these changes

@richardlt richardlt richardlt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sguiheux @ovh-cds @yesnault @fsamin @richardlt

Comments