Thanks to visit codestin.com
Credit goes to github.com

feat: add OAuth2 support #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

deathiop merged 1 commit into master from oauth2

Apr 16, 2024

Member

rbeuque74 commented Dec 22, 2023

Resolves #76

rbeuque74 self-assigned this

rbeuque74 mentioned this pull request

Feature request: add support for oauth2 access token authentication #76

Closed

c-roussel reviewed

View reviewed changes

ovh/configuration.go Outdated Show resolved Hide resolved

ovh/ovh.go Show resolved Hide resolved

ovh/ovh.go Outdated Show resolved Hide resolved

deathiop reviewed

View reviewed changes

ovh/configuration_test.go Outdated Show resolved Hide resolved

rbeuque74 force-pushed the oauth2 branch from 133b8b8 to 44eb0dd Compare

March 22, 2024 16:44

rbeuque74 requested review from c-roussel and deathiop

March 22, 2024 16:49

rbeuque74 marked this pull request as ready for review

March 29, 2024 17:09

rbeuque74 requested review from a-beudin, amstuta and mxpetit as code owners

March 29, 2024 17:09

Contributor

amstuta commented Apr 2, 2024

We should add something in the README to mention this authentication method, otherwise all good

deathiop reviewed

View reviewed changes

ovh/ovh.go Outdated Show resolved Hide resolved

deathiop reviewed

View reviewed changes

go.mod Outdated Show resolved Hide resolved

deathiop reviewed

View reviewed changes

ovh/configuration.go Show resolved Hide resolved

deathiop reviewed

View reviewed changes

ovh/configuration.go Show resolved Hide resolved

deathiop reviewed

View reviewed changes

ovh/configuration.go Show resolved Hide resolved

Contributor

deathiop commented Apr 2, 2024

We should probably have a few tests with httpmock mocking success and failure from the OAuth2 token URL

rbeuque74 force-pushed the oauth2 branch 2 times, most recently from 73ba5a1 to 1ba0758 Compare

April 3, 2024 17:13

rbeuque74 requested a review from deathiop

April 3, 2024 17:14

amstuta previously approved these changes

View reviewed changes

deathiop reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

deathiop reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

deathiop reviewed

View reviewed changes

ovh/ovh_test.go Outdated Show resolved Hide resolved


          feat: add OAuth2 support

fa48fc7

Resolves #76

Signed-off-by: Romain Beuque <[email protected]>

rbeuque74 dismissed amstuta’s stale review via

fa48fc7

April 10, 2024 14:06

rbeuque74 force-pushed the oauth2 branch from 1ba0758 to fa48fc7 Compare

April 10, 2024 14:06

rbeuque74 requested review from amstuta and deathiop

April 10, 2024 14:07

amstuta approved these changes

View reviewed changes

deathiop approved these changes

View reviewed changes

deathiop merged commit 18be085 into master

deathiop deleted the oauth2 branch

April 16, 2024 10:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet