feat(kmipclient): ClientConnectionPool (connection pool + fallback) #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename `ClientNetworkConnection` -> `ClientConnectionPool` (add deprecated alias) - Add constructors `NewClientConnectionPoolContext` and `NewClientConnectionPool` - Keep backward-compatible wrappers (`NewClientNetworkConnection*`, `DialWithFallback` delegating) - Improve fallback logic and connection handling in `kmipclient/network_executor.go` - Add tests in `kmipclient/network_executor_test.go`: - TestClientNetworkConnection_Fallback - TestClientConnectionPool_PrimaryUpNoFallback - TestClientConnectionPool_AllDownError - TestClientConnectionPool_IntermittentRecovery - Add `kmiptest` helpers (`NewServerWithHandle`, cert/listener helpers) to support tests - Fix test cleanup and lint warnings BREAKING CHANGE: exported type renamed from `ClientNetworkConnection` to `ClientConnectionPool`; a compatibility alias and wrappers are provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a connection-pool based network executor for KMIP clients with automatic fallback between endpoints and tests that validate fallback and recovery behavior.
Changes (high level)
Core: Implement ClientConnectionPool with dial-on-demand, per-endpoint cooldown, and fallback iteration.
Constructors: Add NewClientConnectionPoolContext and NewClientConnectionPool
Tests: Add unit tests exercising fallback and recovery.