Upgrade to ocamlformat 0.15.0#535
Merged
ryanrhymes merged 1 commit intoowlbarn:masterfrom Jul 20, 2020
gpetiot:ocamlformat-0.15.0
Merged
Upgrade to ocamlformat 0.15.0#535ryanrhymes merged 1 commit intoowlbarn:masterfrom gpetiot:ocamlformat-0.15.0
ryanrhymes merged 1 commit intoowlbarn:masterfrom
gpetiot:ocamlformat-0.15.0
Conversation
mseri
approved these changes
Jul 14, 2020
Member
mseri
left a comment
There was a problem hiding this comment.
Looks good, if anything I like it more than the previous style
ryanrhymes
approved these changes
Jul 14, 2020
mseri
added a commit
to mseri/opam-repository
that referenced
this pull request
Oct 4, 2020
CHANGES: * various documentation improvements (thanks @pveber, @UnixJunkie, @Fourchaux) * Fix use of access operators (owlbarn/owl#543) * Upgrade to ocamlformat 0.15.0 (thanks @gpetiot owlbarn/owl#535) * keep_dims option (owlbarn/owl#531) * stats: fix infinite loop in ecdf * Use Fun.protect to ensure all file descriptors are being closed * owl_ndarray_maths: improve user experience in case of errors * owl_io: close file descriptors also in case of errors * owl_dense_ndarray_generic: fix error on printing 0-ary arrays * fixed bug in sub forward mode (owlbarn/owl#533) * Add stack to Algodiff (owlbarn/owl#528) * added log_sum_exp to Ndarray and Algodiff (owlbarn/owl#527) * added single-precision and double-precision Bessel functions to Ndarray (owlbarn/owl#526) * Fixes owlbarn/owl#518 by introducing another `/` to resolve data directory (@jotterbach owlbarn/owl#519) * Graph Slice node (resolves owlbarn/owl#483) (@mreppen owlbarn/owl#517) * Graph subnetwork: Multiple outputs (@mreppen owlbarn/owl#515) * Added kron and swap to Algodiff operations (owlbarn/owl#512) * various other small fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is what the project would look like after being reformatted with the current version (candidate) of ocamlformat 0.15.0.
Please do not merge until ocamlformat.0.15.0 is available with opam.
The main changes you see are due to moving the attributes moving to be placed next to the
endkeyword of classes and modules. This change has been made for thejanestreetprofile because JaneStreet is postprocessing its code with ocp-indent and having the attribute on its own line afterendwas weirdly indented by ocp-indent.