Conversation
|
Thanks! |
|
I would be in favour of merging progressively the patches. |
|
@kkirstein can you update the appropriate opam files to add a lower bound on both the new |
|
Fantastic, thanks |
|
I am going to merge these changes. I will make a new release once windows passes all the tests |
|
Thanks to Kay-Uwe for investigating and helping with this issue. Looks like the C macros I have implemented a long time ago needs some improvement on the Windows OS. However, I find that with the recent code, several examples such as I will try to track down this problem when I'm available. But be it a bug or not, it does involve the issue of proper code reviewing. Perhaps it goes unnoticed by some of us, but recently Liang and I have just added a set of project governance rules, involving the team structure, PR, making releases, etc. E.g. one of them requires that a PR be reviewed by at least two team members. (I was planning to check this PR tonight, and thought we can at least wait for a while on it :) Currently we are considering restructuring the team, since the working environment has changed a lot for both of us for now. And this governance is part of this management procedure. I do believe that it will be followed by the community from now on, so as to ensure the team can achieve a mutual understanding of the current project progress, and that this project can grow healthily in a controllable manner. |
This is a first step towards Windows compatibility. Feel free to start merging or wait for the remaining issues to be fixed, depending on your release plans.
Currently,
Owl_maths.mulmodandOwl_maths.powmodcrash; other tests pass. I don't see any special reason for this, but compilation warnings give hints that there are symbol clashes "around"math.h. I will further investigate this.You can find some docs and status in
INSTALL_WINDOWS.md