Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[a11y] Accessibility reports in 4.5.1 #4573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2025
Merged

[a11y] Accessibility reports in 4.5.1 #4573

merged 4 commits into from
Apr 16, 2025

Conversation

@JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Apr 15, 2025 •
edited
Loading

Related Issues

App: #4568

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@JuancaG05 JuancaG05 requested a review from joragua April 15, 2025 12:48
@JuancaG05 JuancaG05 linked an issue Apr 15, 2025 that may be closed by this pull request
[a11y] Accessibility reports in 4.5.1 #4568
Closed
3 tasks
joragua
joragua approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 16, 2025

File list: the "Close" button represented by a cross in the bottom sheet of the 3-dot menu doesn't have a content description

Fixed ✅

Share: when there is more than 1 row in the list of private shares and public links, all the equal buttons among rows have the same content description

Fixed ✅

Manage accounts: when there is more than 1 row in the list of accounts, all the equal buttons among rows have the same content description

Fixed ✅

Let's go with this one

@JuancaG05 JuancaG05 merged commit 5079853 into master Apr 16, 2025
7 checks passed
@JuancaG05 JuancaG05 deleted the feature/accessibility_new_content_descriptions branch April 16, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joragua joragua joragua approved these changes

Assignees

No one assigned

Labels

Approved by qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[a11y] Accessibility reports in 4.5.1

5 participants

@JuancaG05 @jesmrec @joragua @ownclouders