when creating self group-reshare do not share to self #38581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
eadf8fa to
e4122a1
Compare
2 tasks
phil-davis
reviewed
Mar 29, 2021
tests/acceptance/features/webUISharingInternalGroups2/shareWithGroupsEdgeCases.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUISharingInternalGroups2/shareWithGroupsEdgeCases.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUISharingInternalGroups2/shareWithGroupsEdgeCases.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUISharingInternalGroups2/shareWithGroupsEdgeCases.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUISharingInternalGroups2/shareWithGroupsEdgeCases.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUISharingInternalGroups2/shareWithGroupsEdgeCases.feature
Outdated
Show resolved
Hide resolved
|
Code looks good 👍 . Waiting for movement on the acceptance test's comments |
e4122a1 to
6d58407
Compare
phil-davis
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
I refactored some steps at the end of a scenario to be:
And user "Alice" should be able to create folder "/simple-empty-folder"
We have other "Then user Alice should be able to do something" steps. This one will also be useful to have (rather than writing and extra When/Then section at the end of a scenario.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/owncloud/enterprise/issues/4382
related #38542
This PR solved the issue where user is resharing with group that himself belongs to, and where further resharing or increasing permissions is not possible due to self-share with reduced permission