Custom test groups feature #1154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebasing.
viyatb
requested changes
Aug 15, 2021
Member
viyatb
left a comment
There was a problem hiding this comment.
left some comments. I would add some tests for the backend and frontend changes so that we can be sure that these changes don't break the existing functionality.
| if action == "add": | ||
| plugin_data_list = plugin_data.split("&") | ||
| plugin_dict = {} | ||
| for plugin_element in plugin_data_list: |
Member
There was a problem hiding this comment.
this parsing seems weird -- I think urlparsing these parameters into a dictionary or a list would be a cleaner approach.
| plugin_dict = {} | ||
| for plugin_element in plugin_data_list: | ||
| plugin_dict[plugin_element.split("=")[0]] = plugin_element.split("=")[1] | ||
| custom_group_name = plugin_dict['group'].split('%3B')[-1] |
| plugin_data = plugin_data.split("=") | ||
| if plugin_data[0] == "group": | ||
| if "%" in plugin_data[1]: | ||
| groups = plugin_data[1].split('%2C') |
| if criteria.get("group", None): | ||
| if isinstance(criteria["group"], str): | ||
| query = query.filter(Plugin.group == criteria["group"]) | ||
| plugin_groups_list = Plugin.get_all_plugin_groups(session) |
Member
There was a problem hiding this comment.
can you write some tests for this? this is a critical piece of code which might break functionality
| const requestURL = `${API_BASE_URL}group/add`; | ||
| const options = { | ||
| headers: { | ||
| 'Content-Type': 'application/x-www-form-urlencoded;charset=UTF-8', |
Member
There was a problem hiding this comment.
JSON based POST will be simpler than form encoded parameters to parse here imo
| const requestURL = `${API_BASE_URL}group/delete`; | ||
| const options = { | ||
| headers: { | ||
| 'Content-Type': 'application/x-www-form-urlencoded;charset=UTF-8', |
Contributor
Author
|
Thank you! Working on them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A feature to create custom plugin groups from the front end. The user can select plugins and create groups according to their convenience and execute a custom list of plugins
Description
Add groups functionality:
Steps:
Select plugins & click add group
Enter plugin group name
Groups added:
Delete groups functionality:
Motivation and Context
The reason for adding this feature is to make it easy for the user to run specific plugins that they run frequently and need to select them repeatedly. This feature aims to reduce this hassle.
Reviewers
@viyatb @sharmamohit123
Types of changes
Checklist: