Bugfix: If the callback function changes we re-render #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if the callback function changes then we end up re-loading the token. We shouldn't be doing this because in a functional react component the function might well not be the same between renders.
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the token retriever hook so that it only re-fetches when the LTI server URL changes, not when the handleJwt callback identity changes.
- Removed
handleJwtfrom theuseEffectdependency array - Locked the effect to rerun exclusively on
ltiServerupdates
Comments suppressed due to low confidence (1)
src/components/tokenRetriever/LtiTokenRetriever.jsx:71
- Introduce or update a unit test to assert that
fetchTokenonly runs whenltiServerchanges and does not re-run on changes to thehandleJwtcallback identity.
fetchToken();
As we don't re-fetch upon the function changing this isn't so serious any more, however it's an indication that the component is being mis-used, and so we try to be helpful.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the callback function changes then we end up re-loading the token. We shouldn't be doing this because in a functional react component the function might well not be the same between renders.