fix(linter): Fix the `react/jsx-fragments` rule config to take a string argument #16175

connorshea · 2025-11-26T23:55:56Z

The original rule has a config option in the format of ["error", "element"] or ["error", "syntax"]. We required a config object like ["error", { "mode": "element" }], which is technically incompatible for existing configs that get migrated to oxlint.

This fixes that in the generated docs, and also makes it work correctly in the oxlint config. We retain compatibility with the object syntax in case anyone has set up oxlint with it already, and I've added tests to ensure both formats of the config option work.

Generated docs now:

## Configuration

This rule accepts one of the following string values:

### `"syntax"`

This is the default mode. It will enforce the shorthand syntax for React fragments, with one exception.
Keys or attributes are not supported by the shorthand syntax, so the rule will not warn on standard-form fragments that use those.

Examples of **incorrect** code for this rule:
\```jsx
<React.Fragment><Foo /></React.Fragment>
\```

Examples of **correct** code for this rule:
\```jsx
<><Foo /></>
\```

\```jsx
<React.Fragment key="key"><Foo /></React.Fragment>
\```

### `"element"`

This mode enforces the standard form for React fragments.

Examples of **incorrect** code for this rule:
\```jsx
<><Foo /></>
\```

Examples of **correct** code for this rule:
\```jsx
<React.Fragment><Foo /></React.Fragment>
\```

\```jsx
<React.Fragment key="key"><Foo /></React.Fragment>
\```

graphite-app · 2025-11-26T23:56:03Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

Copilot

Pull request overview

This PR fixes the react/jsx-fragments rule configuration to accept string arguments (e.g., ["syntax"] or ["element"]) for compatibility with the original ESLint rule, while maintaining backward compatibility with the previously-implemented object syntax (e.g., [{"mode": "element"}]).

Key Changes

Modified configuration parsing to support both string-based and object-based argument formats
Updated diagnostic messages and help text with improved formatting (backticks and periods)
Added comprehensive test cases for both configuration formats

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/oxc_linter/src/rules/react/jsx_fragments.rs	Refactored configuration parsing to accept both string and object arguments; improved diagnostic message formatting; added test cases for both configuration formats
crates/oxc_linter/src/snapshots/react_jsx_fragments.snap	Updated test snapshots to reflect improved diagnostic message formatting with backticks and periods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codspeed-hq · 2025-11-27T00:01:09Z

CodSpeed Performance Report

Merging #16175 will not alter performance

_{Comparing react-fragment-string-arg (5379f68) with main (75249e0)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

No successful run was found on main (91a1833) during the generation of this report, so 75249e0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

crates/oxc_linter/src/rules/react/jsx_fragments.rs

camc314 · 2025-12-05T15:46:14Z

Merge activity

Dec 5, 3:46 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 5, 3:46 PM UTC: camc314 added this pull request to the Graphite merge queue.
Dec 5, 3:51 PM UTC: Merged by the Graphite merge queue.

…ng argument (#16175) The [original rule](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-fragments.md) has a config option in the format of `["error", "element"]` or `["error", "syntax"]`. We required a config object like `["error", { "mode": "element" }]`, which is technically incompatible for existing configs that get migrated to oxlint. This fixes that in the generated docs, and also makes it work correctly in the oxlint config. We retain compatibility with the object syntax in case anyone has set up oxlint with it already, and I've added tests to ensure both formats of the config option work. Generated docs now: ```md ## Configuration This rule accepts one of the following string values: ### `"syntax"` This is the default mode. It will enforce the shorthand syntax for React fragments, with one exception. Keys or attributes are not supported by the shorthand syntax, so the rule will not warn on standard-form fragments that use those. Examples of **incorrect** code for this rule: \```jsx <React.Fragment><Foo /></React.Fragment> \``` Examples of **correct** code for this rule: \```jsx <><Foo /></> \``` \```jsx <React.Fragment key="key"><Foo /></React.Fragment> \``` ### `"element"` This mode enforces the standard form for React fragments. Examples of **incorrect** code for this rule: \```jsx <><Foo /></> \``` Examples of **correct** code for this rule: \```jsx <React.Fragment><Foo /></React.Fragment> \``` \```jsx <React.Fragment key="key"><Foo /></React.Fragment> \``` ```

# Oxlint ### 🚀 Features - 5c62c16 linter/plugins: Allow JS plugins to access `globals` (#16512) (Arsh) - ba7bd51 linter: Implement no-useless-return rule (#16388) (FMP1783) - fa605df linter: Fix `arrow-body-style` automatically (#16252) (Hamir Mahal) - 7584938 linter/plugins: Add ESLint compat mode to `RuleTester` (#16538) (overlookmotel) - b38c2d0 linter/plugins: Add `SourceCode#lineStartIndices` getter (#16510) (overlookmotel) - ba93ffc linter/plugins: Add `SourceCode#tokensAndComments` getter (#16503) (overlookmotel) - d2ca540 linter/plugins: Add `SourceCode#isESTree` property (#16499) (overlookmotel) - 9001234 linter: Add fix support for tsgolint diagnostics (#16344) (camc314) - 2d6bb85 editors: Toggle client after vscode config changing (#16162) (Liang Mi) - 0ec454c linter/plugins: Merge default options into options (#16358) (overlookmotel) ### 🐛 Bug Fixes - a806d74 linter: Use import type for ESTree in visitor.d.ts (#16472) (camc314) - 8933c84 linter: Fix jest/expect-expect rule docs. (#16550) (connorshea) - 1c08879 linter: Fix false positive in no-invalid-fetch-options for conditional expressions (#16570) (camc314) - 1a69b06 linter: Junit support for multiple files/errors/diagnostics (#16568) (Shrey Sudhir) - a7d435b linter/sort-keys: Preserve multi-line formatting in autofix (#16563) (camc314) - fd84dcc linter/plugins: `RuleTester` parser catch fatal errors (#16558) (overlookmotel) - ab4deb0 linter/plugins: Improve safety of options merging (#16549) (overlookmotel) - a58c76a linter: Fix the `react/jsx-fragments` rule config to take a string argument (#16175) (connorshea) - f7751cc linter/plugins: Fix TS types for `RuleTester` (#16546) (overlookmotel) - 6d33320 linter/plugins: Prevent user modifying the default config (#16545) (overlookmotel) - b4483c5 linter/plugins: Add config support skeleton to `RuleTester` (#16537) (overlookmotel) - 3a49158 linter/plugins: Improve TS types for tokens (#16502) (overlookmotel) - 0c14531 oxlint/lsp: Revalidate all known files after internal restart (#16407) (Sysix) - 2d3217e linter/plugins: Remove panics from `lint_file` and `setup_configs` (#16453) (overlookmotel) - 655341b linter/oxc: Not emit error when the threshold is zero and we haven't detected a barrel file (#16455) (Said Atrahouch) - b9f359f linter/no-var: Expand fix span to prevent conflicts with other rules (#16445) (camc314) - c6778f3 linter: Preserve original quote style in no-hex-escape fixer (#16410) (camc314) - 3ad913b linter: Improve rule docs page autofix description (#16281) (Hamir Mahal) - 0b7e00c linter: Handle keyword unary expressions in yoda rule fix (#16402) (camc314) - 5fd3096 lsp: Skip (un)registering file watcher when not dynamic watchers are supported (#16406) (Sysix) - 804144f lsp: Respect `null` as invalid settings for `workspace/didChangeConfiguration` (#16361) (Sysix) - 723a7e5 linter: Prevent invalid BigInt literal fix for exponential notation (#16401) (camc314) - 2589fb1 linter: Fix prefer_expect_resolves fixer for member expressions (#16393) (camc314) - 428c7cd linter: Wrap logical expressions in parentheses when fixing no-extra-boolean-cast (#16363) (camc314) - 3903567 linter: Skip prefer-string-raw in type annotations and .d.ts files (#16382) (camc314) - d490daa linter/func-names: Use centralized reserved keyword check and fix ancestor traversal (#16362) (camc314) - d846c53 tsgolint: Use `expect` when sending diagnostics (#16341) (camc314) - 114665d lsp: Watch for files when workspace folder is added & `workspace/configuration` is not supported (#16307) (Sysix) - f5d0ebb linter/func-names: Avoid suggesting reserved keywords as function names (#16352) (camc314) - d268135 linter/no-console-spaces: Preserve escape sequences in fixer output (#16349) (camc314) - b02c21a linter/valid-title: Preserve escape sequences in fixer output (#16348) (camc314) - 2373b76 linter/no-untyped-mock-factory: Fix fixer producing invalid syntax when newline exists after opening paren (#16351) (camc314) ### ⚡ Performance - 67cfa58 lsp: Avoid some clones (#16519) (Sysix) - 2a09665 oxlint/lsp: Store only `LinterCodeAction` instead of the complete `DiagnosticReport` (#16516) (Sysix) - 0ca9754 lsp: Avoid `Uri` to `String` and back to `Uri` conversion (#16470) (Sysix) - 2736636 lsp: Avoid cloning when revalidating diagnostics (#16469) (Sysix) - 793b989 linter/plugins: Move result-processing work off main JS thread (#16456) (overlookmotel) - 44dff7b linter/plugins: Skip serialization overhead when no errors (#16443) (overlookmotel) - 1aa2409 linter/plugins: Do not remove `messageId` field from `DiagnosticReport` before sending to Rust (#16442) (overlookmotel) - 5017db8 linter/plugins: Reduce calls to `Path::to_string_lossy` (#16429) (overlookmotel) - 194e357 linter: Use `SmallVec` for rule options (#16400) (Copilot) - e31b2bd linter: Only clone config if required (#16350) (overlookmotel) - 3026086 linter: Avoid cloning rule options (#16338) (overlookmotel) ### 📚 Documentation - fef77af linter: Fix `jsx-a11y/img-redundant-alt` configuration option names. (#16552) (connorshea) - c0766df linter: Add config option docs for `unicorn/filename-case` rule. (#16280) (connorshea) - e24aabd linter/plugins: Correct comment (#16559) (overlookmotel) - 514c724 linter: Fix the name of the IIFEs config option in eslint/max-lines-per-function (#16554) (connorshea) - 4d94438 linter/rules: Correct arrow body style options in documentation (#16509) (GRK) - 6bac4ec linter: Pull configuration struct doc comment when rendering config docs (#16288) (connorshea) - 8c85e08 linter/plugins: Add TODO comment (#16511) (overlookmotel) - a9b9298 linter/plugins: Add JSDoc comments to `SourceCode` properties (#16497) (overlookmotel) - 467cc1a linter/plugins: Improve comment on error branch (#16464) (overlookmotel) - 041b119 linter: Add config option docs to `jest/consistent-test-it` rule. (#16286) (connorshea) ### 🛡️ Security - d90ef9f deps: Update dependency rolldown to v1.0.0-beta.53 (#16428) (renovate[bot]) # Oxfmt ### 🚀 Features - 3184f17 oxfmt: Pass filepath field to prettier formatting (#16591) (Yuji Sugiura) - 7bb3304 oxfmt: Pass populated config to prettier formatting (#16584) (leaysgur) - 69f84d2 oxfmt: Pass raw config to prettier formatting (#16582) (leaysgur) - a83a2ec oxfmt: Expose `setupConfig(configJSON: string)` napi callback (#16579) (leaysgur) - 930533f formatter: Convert single `\r` to `\n` in string and add a debug assertion to ensure that there is no `\r` in the text (#16531) (Dunqing) - af76b0e oxfmt: Support formatting HTML, YAML, GraphQL, Handlerbars, Markdown, CSS files (#16524) (leaysgur) - 66b64ef oxfmt: Support formatting JSON files (#16523) (leaysgur) - 4767926 oxfmt: Prepare non-js/ts file support with prettier (#16480) (leaysgur) - 2b4ce5d oxfmt: Use dedicated `format_by_xxx_formatter` method by `SourceType` (#16417) (leaysgur) - 0867d2f oxfmt: Set up JS `formatFile()` function for Rust via napi (#16415) (leaysgur) - b6feb66 oxfmt: Rename `embedded.ts` with preparing `formatFile()` function (#16414) (leaysgur) - 80e6999 formatter: Add debug assertion to ensure that there is no empty content is passed in (#16475) (Dunqing) - 7374856 formatter/sort-imports: Support `options.internalPattern` (#16372) (leaysgur) - dd2cb62 oxfmt: Not error on explicit `--write` flag used (#16376) (leaysgur) ### 🐛 Bug Fixes - 40b0134 formatter: Incorrect formatting of `useImperativeHandle` hook (#16533) (Dunqing) - 75393e7 formatter: Incorrect handling of `CRLF` for multiline block comment (#16528) (Dunqing) - ee0756b formatter: JSX text wrapping incorrect 2 (#16320) (Dunqing) - 36308b8 formatter: Fix indent for new expression with type cast (#16380) (leaysgur) ### ⚡ Performance - 6f16a8f formatter: Avoid using an indent with a empty content (#16474) (Dunqing) - 201c98f formatter: Early return when no comments need to be printed (#16432) (Dunqing) Co-authored-by: Boshen <[email protected]>

…ng argument (oxc-project#16175) The [original rule](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-fragments.md) has a config option in the format of `["error", "element"]` or `["error", "syntax"]`. We required a config object like `["error", { "mode": "element" }]`, which is technically incompatible for existing configs that get migrated to oxlint. This fixes that in the generated docs, and also makes it work correctly in the oxlint config. We retain compatibility with the object syntax in case anyone has set up oxlint with it already, and I've added tests to ensure both formats of the config option work. Generated docs now: ```md ## Configuration This rule accepts one of the following string values: ### `"syntax"` This is the default mode. It will enforce the shorthand syntax for React fragments, with one exception. Keys or attributes are not supported by the shorthand syntax, so the rule will not warn on standard-form fragments that use those. Examples of **incorrect** code for this rule: \```jsx <React.Fragment><Foo /></React.Fragment> \``` Examples of **correct** code for this rule: \```jsx <><Foo /></> \``` \```jsx <React.Fragment key="key"><Foo /></React.Fragment> \``` ### `"element"` This mode enforces the standard form for React fragments. Examples of **incorrect** code for this rule: \```jsx <><Foo /></> \``` Examples of **correct** code for this rule: \```jsx <React.Fragment><Foo /></React.Fragment> \``` \```jsx <React.Fragment key="key"><Foo /></React.Fragment> \``` ```

# Oxlint ### 🚀 Features - 5c62c16 linter/plugins: Allow JS plugins to access `globals` (oxc-project#16512) (Arsh) - ba7bd51 linter: Implement no-useless-return rule (oxc-project#16388) (FMP1783) - fa605df linter: Fix `arrow-body-style` automatically (oxc-project#16252) (Hamir Mahal) - 7584938 linter/plugins: Add ESLint compat mode to `RuleTester` (oxc-project#16538) (overlookmotel) - b38c2d0 linter/plugins: Add `SourceCode#lineStartIndices` getter (oxc-project#16510) (overlookmotel) - ba93ffc linter/plugins: Add `SourceCode#tokensAndComments` getter (oxc-project#16503) (overlookmotel) - d2ca540 linter/plugins: Add `SourceCode#isESTree` property (oxc-project#16499) (overlookmotel) - 9001234 linter: Add fix support for tsgolint diagnostics (oxc-project#16344) (camc314) - 2d6bb85 editors: Toggle client after vscode config changing (oxc-project#16162) (Liang Mi) - 0ec454c linter/plugins: Merge default options into options (oxc-project#16358) (overlookmotel) ### 🐛 Bug Fixes - a806d74 linter: Use import type for ESTree in visitor.d.ts (oxc-project#16472) (camc314) - 8933c84 linter: Fix jest/expect-expect rule docs. (oxc-project#16550) (connorshea) - 1c08879 linter: Fix false positive in no-invalid-fetch-options for conditional expressions (oxc-project#16570) (camc314) - 1a69b06 linter: Junit support for multiple files/errors/diagnostics (oxc-project#16568) (Shrey Sudhir) - a7d435b linter/sort-keys: Preserve multi-line formatting in autofix (oxc-project#16563) (camc314) - fd84dcc linter/plugins: `RuleTester` parser catch fatal errors (oxc-project#16558) (overlookmotel) - ab4deb0 linter/plugins: Improve safety of options merging (oxc-project#16549) (overlookmotel) - a58c76a linter: Fix the `react/jsx-fragments` rule config to take a string argument (oxc-project#16175) (connorshea) - f7751cc linter/plugins: Fix TS types for `RuleTester` (oxc-project#16546) (overlookmotel) - 6d33320 linter/plugins: Prevent user modifying the default config (oxc-project#16545) (overlookmotel) - b4483c5 linter/plugins: Add config support skeleton to `RuleTester` (oxc-project#16537) (overlookmotel) - 3a49158 linter/plugins: Improve TS types for tokens (oxc-project#16502) (overlookmotel) - 0c14531 oxlint/lsp: Revalidate all known files after internal restart (oxc-project#16407) (Sysix) - 2d3217e linter/plugins: Remove panics from `lint_file` and `setup_configs` (oxc-project#16453) (overlookmotel) - 655341b linter/oxc: Not emit error when the threshold is zero and we haven't detected a barrel file (oxc-project#16455) (Said Atrahouch) - b9f359f linter/no-var: Expand fix span to prevent conflicts with other rules (oxc-project#16445) (camc314) - c6778f3 linter: Preserve original quote style in no-hex-escape fixer (oxc-project#16410) (camc314) - 3ad913b linter: Improve rule docs page autofix description (oxc-project#16281) (Hamir Mahal) - 0b7e00c linter: Handle keyword unary expressions in yoda rule fix (oxc-project#16402) (camc314) - 5fd3096 lsp: Skip (un)registering file watcher when not dynamic watchers are supported (oxc-project#16406) (Sysix) - 804144f lsp: Respect `null` as invalid settings for `workspace/didChangeConfiguration` (oxc-project#16361) (Sysix) - 723a7e5 linter: Prevent invalid BigInt literal fix for exponential notation (oxc-project#16401) (camc314) - 2589fb1 linter: Fix prefer_expect_resolves fixer for member expressions (oxc-project#16393) (camc314) - 428c7cd linter: Wrap logical expressions in parentheses when fixing no-extra-boolean-cast (oxc-project#16363) (camc314) - 3903567 linter: Skip prefer-string-raw in type annotations and .d.ts files (oxc-project#16382) (camc314) - d490daa linter/func-names: Use centralized reserved keyword check and fix ancestor traversal (oxc-project#16362) (camc314) - d846c53 tsgolint: Use `expect` when sending diagnostics (oxc-project#16341) (camc314) - 114665d lsp: Watch for files when workspace folder is added & `workspace/configuration` is not supported (oxc-project#16307) (Sysix) - f5d0ebb linter/func-names: Avoid suggesting reserved keywords as function names (oxc-project#16352) (camc314) - d268135 linter/no-console-spaces: Preserve escape sequences in fixer output (oxc-project#16349) (camc314) - b02c21a linter/valid-title: Preserve escape sequences in fixer output (oxc-project#16348) (camc314) - 2373b76 linter/no-untyped-mock-factory: Fix fixer producing invalid syntax when newline exists after opening paren (oxc-project#16351) (camc314) ### ⚡ Performance - 67cfa58 lsp: Avoid some clones (oxc-project#16519) (Sysix) - 2a09665 oxlint/lsp: Store only `LinterCodeAction` instead of the complete `DiagnosticReport` (oxc-project#16516) (Sysix) - 0ca9754 lsp: Avoid `Uri` to `String` and back to `Uri` conversion (oxc-project#16470) (Sysix) - 2736636 lsp: Avoid cloning when revalidating diagnostics (oxc-project#16469) (Sysix) - 793b989 linter/plugins: Move result-processing work off main JS thread (oxc-project#16456) (overlookmotel) - 44dff7b linter/plugins: Skip serialization overhead when no errors (oxc-project#16443) (overlookmotel) - 1aa2409 linter/plugins: Do not remove `messageId` field from `DiagnosticReport` before sending to Rust (oxc-project#16442) (overlookmotel) - 5017db8 linter/plugins: Reduce calls to `Path::to_string_lossy` (oxc-project#16429) (overlookmotel) - 194e357 linter: Use `SmallVec` for rule options (oxc-project#16400) (Copilot) - e31b2bd linter: Only clone config if required (oxc-project#16350) (overlookmotel) - 3026086 linter: Avoid cloning rule options (oxc-project#16338) (overlookmotel) ### 📚 Documentation - fef77af linter: Fix `jsx-a11y/img-redundant-alt` configuration option names. (oxc-project#16552) (connorshea) - c0766df linter: Add config option docs for `unicorn/filename-case` rule. (oxc-project#16280) (connorshea) - e24aabd linter/plugins: Correct comment (oxc-project#16559) (overlookmotel) - 514c724 linter: Fix the name of the IIFEs config option in eslint/max-lines-per-function (oxc-project#16554) (connorshea) - 4d94438 linter/rules: Correct arrow body style options in documentation (oxc-project#16509) (GRK) - 6bac4ec linter: Pull configuration struct doc comment when rendering config docs (oxc-project#16288) (connorshea) - 8c85e08 linter/plugins: Add TODO comment (oxc-project#16511) (overlookmotel) - a9b9298 linter/plugins: Add JSDoc comments to `SourceCode` properties (oxc-project#16497) (overlookmotel) - 467cc1a linter/plugins: Improve comment on error branch (oxc-project#16464) (overlookmotel) - 041b119 linter: Add config option docs to `jest/consistent-test-it` rule. (oxc-project#16286) (connorshea) ### 🛡️ Security - d90ef9f deps: Update dependency rolldown to v1.0.0-beta.53 (oxc-project#16428) (renovate[bot]) # Oxfmt ### 🚀 Features - 3184f17 oxfmt: Pass filepath field to prettier formatting (oxc-project#16591) (Yuji Sugiura) - 7bb3304 oxfmt: Pass populated config to prettier formatting (oxc-project#16584) (leaysgur) - 69f84d2 oxfmt: Pass raw config to prettier formatting (oxc-project#16582) (leaysgur) - a83a2ec oxfmt: Expose `setupConfig(configJSON: string)` napi callback (oxc-project#16579) (leaysgur) - 930533f formatter: Convert single `\r` to `\n` in string and add a debug assertion to ensure that there is no `\r` in the text (oxc-project#16531) (Dunqing) - af76b0e oxfmt: Support formatting HTML, YAML, GraphQL, Handlerbars, Markdown, CSS files (oxc-project#16524) (leaysgur) - 66b64ef oxfmt: Support formatting JSON files (oxc-project#16523) (leaysgur) - 4767926 oxfmt: Prepare non-js/ts file support with prettier (oxc-project#16480) (leaysgur) - 2b4ce5d oxfmt: Use dedicated `format_by_xxx_formatter` method by `SourceType` (oxc-project#16417) (leaysgur) - 0867d2f oxfmt: Set up JS `formatFile()` function for Rust via napi (oxc-project#16415) (leaysgur) - b6feb66 oxfmt: Rename `embedded.ts` with preparing `formatFile()` function (oxc-project#16414) (leaysgur) - 80e6999 formatter: Add debug assertion to ensure that there is no empty content is passed in (oxc-project#16475) (Dunqing) - 7374856 formatter/sort-imports: Support `options.internalPattern` (oxc-project#16372) (leaysgur) - dd2cb62 oxfmt: Not error on explicit `--write` flag used (oxc-project#16376) (leaysgur) ### 🐛 Bug Fixes - 40b0134 formatter: Incorrect formatting of `useImperativeHandle` hook (oxc-project#16533) (Dunqing) - 75393e7 formatter: Incorrect handling of `CRLF` for multiline block comment (oxc-project#16528) (Dunqing) - ee0756b formatter: JSX text wrapping incorrect 2 (oxc-project#16320) (Dunqing) - 36308b8 formatter: Fix indent for new expression with type cast (oxc-project#16380) (leaysgur) ### ⚡ Performance - 6f16a8f formatter: Avoid using an indent with a empty content (oxc-project#16474) (Dunqing) - 201c98f formatter: Early return when no comments need to be printed (oxc-project#16432) (Dunqing) Co-authored-by: Boshen <[email protected]>

connorshea requested a review from camc314 as a code owner November 26, 2025 23:55

Copilot AI review requested due to automatic review settings November 26, 2025 23:55

github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Nov 26, 2025

Copilot started reviewing on behalf of connorshea November 26, 2025 23:56 View session

Copilot finished reviewing on behalf of connorshea November 26, 2025 23:57

Copilot AI reviewed Nov 26, 2025

View reviewed changes

PeterCardenas reviewed Nov 27, 2025

View reviewed changes

crates/oxc_linter/src/rules/react/jsx_fragments.rs Outdated Show resolved Hide resolved

crates/oxc_linter/src/rules/react/jsx_fragments.rs Outdated Show resolved Hide resolved

camc314 self-assigned this Nov 27, 2025

camc314 approved these changes Dec 5, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2025

graphite-app bot force-pushed the react-fragment-string-arg branch from 5379f68 to a58c76a Compare December 5, 2025 15:47

graphite-app bot merged commit a58c76a into main Dec 5, 2025
20 checks passed

graphite-app bot deleted the react-fragment-string-arg branch December 5, 2025 15:51

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 5, 2025

Boshen mentioned this pull request Dec 8, 2025

release(apps): oxlint v1.32.0 && oxfmt v0.17.0 #16596

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(linter): Fix the `react/jsx-fragments` rule config to take a string argument #16175

fix(linter): Fix the `react/jsx-fragments` rule config to take a string argument #16175

Uh oh!

connorshea commented Nov 26, 2025

Uh oh!

graphite-app bot commented Nov 26, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

camc314 commented Dec 5, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

fix(linter): Fix the react/jsx-fragments rule config to take a string argument #16175

fix(linter): Fix the react/jsx-fragments rule config to take a string argument #16175

Uh oh!

Conversation

connorshea commented Nov 26, 2025

Uh oh!

graphite-app bot commented Nov 26, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

codspeed-hq bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #16175 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Dec 5, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(linter): Fix the `react/jsx-fragments` rule config to take a string argument #16175

fix(linter): Fix the `react/jsx-fragments` rule config to take a string argument #16175

codspeed-hq bot commented Nov 27, 2025 •

edited

Loading

camc314 commented Dec 5, 2025 •

edited by graphite-app bot

Loading