CI Updates #154
Merged
CI Updates #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da64c3d to
94e5b0e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nicolasochem
approved these changes
Aug 24, 2023
Contributor
nicolasochem
left a comment
There was a problem hiding this comment.
Thanks. It looks good, I obviously couldn't test it but the CI passed on the pull request. Also I see that you linted release.py
We should merge and I might need your help to fix my local kubeconfig. I'm looking forward to not having to do AWS_PROFILE=oxheadalpha k9s anymore.
|
🍹 The Update (preview) for tqtezos/teztnets/teztnets was successful. Resource Changes Name Type Operation
~ teztnets-vpc-cni eks:index:VpcCni update
~ teztnets-provider pulumi:providers:kubernetes update
~ teztnets-eks-k8s pulumi:providers:kubernetes update
~ nairobinet/tezos-baking-node kubernetes:apps/v1:StatefulSet update
+- nairobinet/tezos-config kubernetes:core/v1:ConfigMap create-replacement
+- nairobinet/activate-job kubernetes:batch/v1:Job create-replacement
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oxheadalphatooxheadalpha_tempKubernetesAdminas the role assumed istempKubernetesAdmin. The way it currently is makes development locally annoying, as the aws profile name must match and include the role. But the plain nameoxheadalpha, indicates just plain creds without assuming a role, and in order to interact with the clluster without it updating the kubeconfig's role name, you need to locally add the role to theoxheadalphaprofile. You will need to update your local teztnets kubeconfig to use a profile namedoxheadalpha_tempKubernetesAdminthat has the role to assume associated with it.